1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00

Merge pull request #26630 from kamipo/quoted_binary

Extract `quoted_binary` and use it rather than override `_quote`
This commit is contained in:
Rafael França 2017-02-13 00:33:56 -03:00 committed by GitHub
commit 2f60a7525e
4 changed files with 17 additions and 20 deletions

View file

@ -141,6 +141,10 @@ module ActiveRecord
quoted_date(value).sub(/\A2000-01-01 /, "")
end
def quoted_binary(value) # :nodoc:
"'#{quote_string(value.to_s)}'"
end
private
def type_casted_binds(binds)
@ -153,7 +157,7 @@ module ActiveRecord
def _quote(value)
case value
when String, ActiveSupport::Multibyte::Chars, Type::Binary::Data
when String, ActiveSupport::Multibyte::Chars
"'#{quote_string(value.to_s)}'"
when true then quoted_true
when false then quoted_false
@ -161,6 +165,7 @@ module ActiveRecord
# BigDecimals need to be put in a non-normalized form and quoted.
when BigDecimal then value.to_s("F")
when Numeric, ActiveSupport::Duration then value.to_s
when Type::Binary::Data then quoted_binary(value)
when Type::Time::Value then "'#{quoted_time(value)}'"
when Date, Time then "'#{quoted_date(value)}'"
when Symbol then "'#{quote_string(value.to_s)}'"

View file

@ -36,14 +36,8 @@ module ActiveRecord
end
end
private
def _quote(value)
if value.is_a?(Type::Binary::Data)
def quoted_binary(value)
"x'#{value.hex}'"
else
super
end
end
end
end

View file

@ -55,6 +55,10 @@ module ActiveRecord
end
end
def quoted_binary(value) # :nodoc:
"'#{escape_bytea(value.to_s)}'"
end
def quote_default_expression(value, column) # :nodoc:
if value.is_a?(Proc)
value.call
@ -76,8 +80,6 @@ module ActiveRecord
def _quote(value)
case value
when Type::Binary::Data
"'#{escape_bytea(value.to_s)}'"
when OID::Xml::Data
"xml '#{quote_string(value.to_s)}'"
when OID::Bit::Data

View file

@ -18,16 +18,12 @@ module ActiveRecord
quoted_date(value)
end
private
def _quote(value)
if value.is_a?(Type::Binary::Data)
def quoted_binary(value)
"x'#{value.hex}'"
else
super
end
end
private
def _type_cast(value)
case value
when BigDecimal