kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Merge pull request #38720 from eileencodes/remove-convenience-class-def

Browse source 
Remove convenience class alias
This commit is contained in:
Eileen M. Uchitelle 2020-03-13 16:26:24 -04:00 committed by GitHub
commit 311b94d495
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
activerecord/lib/arel.rb
View file

@ -43,7 +43,7 @@ module Arel
end
def self.arel_node?(value) # :nodoc:
value.is_a?(Arel::Node) || value.is_a?(Arel::Attribute) || value.is_a?(Arel::Nodes::SqlLiteral)
value.is_a?(Arel::Nodes::Node) || value.is_a?(Arel::Attribute) || value.is_a?(Arel::Nodes::SqlLiteral)
end
def self.fetch_attribute(value, &block) # :nodoc:
@ -59,7 +59,4 @@ module Arel
fetch_attribute(value.expr, &block)
end
end
## Convenience Alias
Node = Arel::Nodes::Node # :nodoc:
end

2
activerecord/test/cases/arel/nodes/node_test.rb
View file

@ -5,7 +5,7 @@ require_relative "../helper"
module Arel
class TestNode < Arel::Test
def test_includes_factory_methods
assert Node.new.respond_to?(:create_join)
assert Arel::Nodes::Node.new.respond_to?(:create_join)
end
def test_all_nodes_are_nodes