mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
Remove "stupid" from active record
The language in the docs is clearer without saying MySQL is stupid. The test doesn't need stupid in the value to be used - an incorrect value is incorrect.
This commit is contained in:
parent
f7cedc6b43
commit
311d0babfb
2 changed files with 2 additions and 2 deletions
|
@ -75,7 +75,7 @@ module Arel # :nodoc: all
|
||||||
end
|
end
|
||||||
alias :prepare_delete_statement :prepare_update_statement
|
alias :prepare_delete_statement :prepare_update_statement
|
||||||
|
|
||||||
# MySQL is too stupid to create a temporary table for use subquery, so we have
|
# MySQL doesn't automatically create a temporary table for use subquery, so we have
|
||||||
# to give it some prompting in the form of a subsubquery.
|
# to give it some prompting in the form of a subsubquery.
|
||||||
def build_subselect(key, o)
|
def build_subselect(key, o)
|
||||||
subselect = super
|
subselect = super
|
||||||
|
|
|
@ -362,7 +362,7 @@ class DefaultScopingTest < ActiveRecord::TestCase
|
||||||
|
|
||||||
def test_unscope_errors_with_invalid_value
|
def test_unscope_errors_with_invalid_value
|
||||||
assert_raises(ArgumentError) do
|
assert_raises(ArgumentError) do
|
||||||
Developer.includes(:projects).where(name: "Jamis").unscope(:stupidly_incorrect_value)
|
Developer.includes(:projects).where(name: "Jamis").unscope(:incorrect_value)
|
||||||
end
|
end
|
||||||
|
|
||||||
assert_raises(ArgumentError) do
|
assert_raises(ArgumentError) do
|
||||||
|
|
Loading…
Reference in a new issue