kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Let's simplify the internal assertion here, doesn't need to a yield argument

Browse source
This commit is contained in:
Kasper Timm Hansen 2021-03-03 15:58:27 +01:00
parent b19cd20f63
commit 32a69da269
No known key found for this signature in database
GPG key ID: 191153215EDA53D8
1 changed files with 7 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
activerecord/test/cases/excluding_test.rb
View file

@ -46,15 +46,10 @@ class ExcludingTest < ActiveRecord::TestCase
end
def test_does_not_exclude_records_when_no_arguments
assert_does_not_exclude_records { Post.excluding() }
end
def test_does_not_exclude_records_with_empty_collection_argument
assert_does_not_exclude_records { Post.excluding([]) }
end
def test_does_not_exclude_records_with_a_nil_argument
assert_does_not_exclude_records { Post.excluding(nil) }
assert_no_excludes Post.excluding
assert_no_excludes Post.excluding(nil)
assert_no_excludes Post.excluding([])
assert_no_excludes Post.excluding([ nil ])
end
def test_raises_on_record_from_different_class
@ -74,8 +69,8 @@ class ExcludingTest < ActiveRecord::TestCase
end
private
def assert_does_not_exclude_records
assert_includes yield, posts(:welcome)
assert_equal Post.count, yield.count
def assert_no_excludes(relation)
assert_includes relation, posts(:welcome)
assert_equal Post.count, relation.count
end
end