kotovalexarian-likes-github
/
rails--rails
mirror of https://github.com/rails/rails.git
1
0
Fork 0
Code Releases Activity

Ruby 1.9: Fix ActiveResource::ConnectionError#to_s when @response does not respond to #code or #message 

Signed-off-by: Carl Lerche <carllerche@mac.com>
This commit is contained in:
Chad Woolley 2009-10-04 01:50:47 -07:00 committed by Carl Lerche
parent 28bd0873ff
commit 32cea98c3b
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
activeresource/lib/active_resource/exceptions.rb
View File

@ -8,7 +8,10 @@ module ActiveResource
end
def to_s
"Failed with #{response.code} #{response.message if response.respond_to?(:message)}"
message = "Failed."
message << " Response code = #{response.code}." if response.respond_to?(:code)
message << " Response message = #{response.message}." if response.respond_to?(:message)
message
end
end

2
activeresource/test/connection_test.rb
View File

@ -83,7 +83,7 @@ class ConnectionTest < Test::Unit::TestCase
begin
handle_response ResponseHeaderStub.new(405, "HTTP Failed...", "GET, POST")
rescue ActiveResource::MethodNotAllowed => e
assert_equal "Failed with 405 HTTP Failed...", e.message
assert_equal "Failed. Response code = 405. Response message = HTTP Failed....", e.message
assert_equal [:get, :post], e.allowed_methods
end
end