Removed support for deprecated insert_sql in associations.

activerecord/CHANGELOG.md

@@ -1,3 +1,7 @@
+*   Removed support for deprecated `insert_sql` in associations.
+
+    *Neeraj Singh*
+
 *   Removed support for deprecated `finder_sql` in associations.
 
     *Neeraj Singh*

activerecord/lib/active_record/associations/builder/has_and_belongs_to_many.rb

@@ -5,7 +5,7 @@ module ActiveRecord::Associations::Builder
     end
 
     def valid_options
-      super + [:join_table, :association_foreign_key, :delete_sql, :insert_sql]
+      super + [:join_table, :association_foreign_key, :delete_sql]
     end
 
     def build

activerecord/lib/active_record/associations/has_and_belongs_to_many_association.rb

@@ -18,16 +18,12 @@ module ActiveRecord
           end
         end
 
-        if options[:insert_sql]
+        stmt = join_table.compile_insert(
-          owner.connection.insert(interpolate(options[:insert_sql], record))
+          join_table[reflection.foreign_key]             => owner.id,
-        else
+          join_table[reflection.association_foreign_key] => record.id
-          stmt = join_table.compile_insert(
+        )
-            join_table[reflection.foreign_key]             => owner.id,
-            join_table[reflection.association_foreign_key] => record.id
-          )
 
-          owner.class.connection.insert stmt
+        owner.class.connection.insert stmt
-        end
 
         record
       end