kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Resolve bug in nested FormBuilder#field_id

Browse source 
As a follow-up to [#40127][], this commit adds a bug fix for nested form
builders (through either `fields_for` or `fields`) incorrectly
constructing a field's `[id]` attribute. To do so, treat the
`@object_name` with higher precedence than the `@object`, since that
will be provided as instance state during construction.

[#40127]: https://github.com/rails/rails/pull/40127
This commit is contained in:
Sean Doyle 2021-07-08 15:45:45 -04:00
parent ac87404bf8
commit 3b34cb9e39
2 changed files with 47 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
actionview/lib/action_view/helpers/form_helper.rb
View file

@ -1728,7 +1728,7 @@ module ActionView
# element, sharing a common <tt>id</tt> root (<tt>post_title</tt>, in this
# case).
def field_id(method, *suffixes, index: @index)
@template.field_id(@object || @object_name, method, *suffixes, index: @index)
@template.field_id(@object_name, method, *suffixes, index: index)
end
##

46
actionview/test/template/form_helper_test.rb
View file

@ -2461,6 +2461,34 @@ class FormHelperTest < ActionView::TestCase
assert_dom_equal expected, output_buffer
end
def test_nested_fields_for_field_id
form_for(@post) do |form|
concat form.fields_for(:comment_attributes, @comment) { |c|
concat c.field_id(:body)
}
end
expected = whole_form("/posts/123", "edit_post_123", "edit_post", method: "patch") do
"post_comment_attributes_body"
end
assert_dom_equal expected, output_buffer
end
def test_nested_fields_for_field_id_with_index_override
form_for(@post) do |form|
concat form.fields_for(:comment_attributes, @comment, index: 1) { |c|
concat c.field_id(:body)
}
end
expected = whole_form("/posts/123", "edit_post_123", "edit_post", method: "patch") do
"post_comment_attributes_1_body"
end
assert_dom_equal expected, output_buffer
end
def test_deep_nested_fields_for
@comment.save
form_for(:posts) do |f|
@ -3240,6 +3268,12 @@ class FormHelperTest < ActionView::TestCase
assert_dom_equal expected, output_buffer
end
def test_fields_for_field_id
fields_for(:post, @post) do |fields|
assert_equal "post_title", fields.field_id(:title)
end
end
def test_fields_for_with_index
output_buffer = fields_for("post[]", @post) do |f|
concat f.text_field(:title)
@ -3256,6 +3290,12 @@ class FormHelperTest < ActionView::TestCase
assert_dom_equal expected, output_buffer
end
def test_fields_for_field_id_with_index_option
fields_for(:post, @post) do |fields|
assert_equal "post_5_title", fields.field_id(:title, index: 5)
end
end
def test_fields_for_with_nil_index_option_override
output_buffer = fields_for("post[]", @post, index: nil) do |f|
concat f.text_field(:title)
@ -3272,6 +3312,12 @@ class FormHelperTest < ActionView::TestCase
assert_dom_equal expected, output_buffer
end
def test_fields_for_with_index_option_override_field_id
fields_for(:post, @post, index: 1) do |fields|
assert_equal "post_1_title", fields.field_id(:title)
end
end
def test_fields_for_with_index_option_override
output_buffer = fields_for("post[]", @post, index: "abc") do |f|
concat f.text_field(:title)