From 210bf6aa39756b15fedfc46ce2efce7ad051fd2a Mon Sep 17 00:00:00 2001 From: Bibek Shrestha Date: Mon, 16 Dec 2019 18:46:04 -0500 Subject: [PATCH] Remove stacktrace from ActiveJob logging callback halts ActiveJob will log the entire backtrace when one of the enqueue callbacks fail. This is not necessary and increases noise. When there is an Exception object, the object gets bubbled up eventually anyways. Remove `Array(ex.backtrace).join("\n")` from `def enqueue` and `def enqueue_at`. --- activejob/lib/active_job/log_subscriber.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/activejob/lib/active_job/log_subscriber.rb b/activejob/lib/active_job/log_subscriber.rb index 0cf53db2eb..66cc51e8b9 100644 --- a/activejob/lib/active_job/log_subscriber.rb +++ b/activejob/lib/active_job/log_subscriber.rb @@ -10,7 +10,7 @@ module ActiveJob if ex error do - "Failed enqueuing #{job.class.name} to #{queue_name(event)}: #{ex.class} (#{ex.message}):\n" + Array(ex.backtrace).join("\n") + "Failed enqueuing #{job.class.name} to #{queue_name(event)}: #{ex.class} (#{ex.message})" end elsif event.payload[:aborted] info do @@ -29,7 +29,7 @@ module ActiveJob if ex error do - "Failed enqueuing #{job.class.name} to #{queue_name(event)}: #{ex.class} (#{ex.message}):\n" + Array(ex.backtrace).join("\n") + "Failed enqueuing #{job.class.name} to #{queue_name(event)}: #{ex.class} (#{ex.message})" end elsif event.payload[:aborted] info do