1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00

remove meaningless use of Relation#all

particularly, `all(options)` would warn
This commit is contained in:
Akira Matsuda 2013-01-03 23:38:31 +09:00
parent 79255fab89
commit 3d1bc89ec8
3 changed files with 4 additions and 4 deletions

View file

@ -165,7 +165,7 @@ module ActiveRecord
# by specifying an instance of the value object in the conditions hash. The following example # by specifying an instance of the value object in the conditions hash. The following example
# finds all customers with +balance_amount+ equal to 20 and +balance_currency+ equal to "USD": # finds all customers with +balance_amount+ equal to 20 and +balance_currency+ equal to "USD":
# #
# Customer.where(balance: Money.new(20, "USD")).all # Customer.where(balance: Money.new(20, "USD"))
# #
module ClassMethods module ClassMethods
# Adds reader and writer methods for manipulating a value object: # Adds reader and writer methods for manipulating a value object:

View file

@ -194,7 +194,7 @@ module ActiveRecord
# * <tt>Project#project_manager, Project#project_manager=(project_manager), Project#project_manager.nil?,</tt> # * <tt>Project#project_manager, Project#project_manager=(project_manager), Project#project_manager.nil?,</tt>
# * <tt>Project#milestones.empty?, Project#milestones.size, Project#milestones, Project#milestones<<(milestone),</tt> # * <tt>Project#milestones.empty?, Project#milestones.size, Project#milestones, Project#milestones<<(milestone),</tt>
# <tt>Project#milestones.delete(milestone), Project#milestones.destroy(mileston), Project#milestones.find(milestone_id),</tt> # <tt>Project#milestones.delete(milestone), Project#milestones.destroy(mileston), Project#milestones.find(milestone_id),</tt>
# <tt>Project#milestones.all(options), Project#milestones.build, Project#milestones.create</tt> # <tt>Project#milestones.build, Project#milestones.create</tt>
# * <tt>Project#categories.empty?, Project#categories.size, Project#categories, Project#categories<<(category1),</tt> # * <tt>Project#categories.empty?, Project#categories.size, Project#categories, Project#categories<<(category1),</tt>
# <tt>Project#categories.delete(category1), Project#categories.destroy(category1)</tt> # <tt>Project#categories.delete(category1), Project#categories.destroy(category1)</tt>
# #
@ -743,7 +743,7 @@ module ActiveRecord
# other than the main one. If this is the case Active Record falls back to the previously # other than the main one. If this is the case Active Record falls back to the previously
# used LEFT OUTER JOIN based strategy. For example # used LEFT OUTER JOIN based strategy. For example
# #
# Post.includes([:author, :comments]).where(['comments.approved = ?', true]).all # Post.includes([:author, :comments]).where(['comments.approved = ?', true])
# #
# This will result in a single SQL query with joins along the lines of: # This will result in a single SQL query with joins along the lines of:
# <tt>LEFT OUTER JOIN comments ON comments.post_id = posts.id</tt> and # <tt>LEFT OUTER JOIN comments ON comments.post_id = posts.id</tt> and

View file

@ -26,7 +26,7 @@ module ActiveRecord
# #
# Account.transaction do # Account.transaction do
# # select * from accounts where ... # # select * from accounts where ...
# accounts = Account.where(...).all # accounts = Account.where(...)
# account1 = accounts.detect { |account| ... } # account1 = accounts.detect { |account| ... }
# account2 = accounts.detect { |account| ... } # account2 = accounts.detect { |account| ... }
# # select * from accounts where id=? for update # # select * from accounts where id=? for update