AS::Callbacks::Callback refactor

In order to make Callbacks code always operate on valid peaces of code
Concatenated Callback#start and Callback#end method into #apply
method.

activesupport/lib/active_support/callbacks.rb

@@ -158,19 +158,10 @@ module ActiveSupport
         RUBY_EVAL
       end
 
-      # This will supply contents for before and around filters, and no
+      # Wraps code with filter
-      # contents for after filters (for the forward pass).
+      def apply(code, key=nil, object=nil)
-      def start(key=nil, object=nil)
-        return if key && !object.send("_one_time_conditions_valid_#{@callback_id}?")
-
-        # options[0] is the compiled form of supplied conditions
-        # options[1] is the "end" for the conditional
-        #
         case @kind
         when :before
-          # if condition    # before_save :filter_name, :if => :condition
-          #   filter_name
-          # end
           <<-RUBY_EVAL
             if !halted && #{@compiled_options}
               # This double assignment is to prevent warnings in 1.9.3.  I would
@@ -180,8 +171,33 @@ module ActiveSupport
               result = result = #{@filter}
               halted = (#{chain.config[:terminator]})
             end
+            #{code}
+          RUBY_EVAL
+        when :after
+          <<-RUBY_EVAL
+          #{code}
+          if #{@compiled_options}
+            #{@filter}
+          end
           RUBY_EVAL
         when :around
+          name = define_conditional_callback
+          <<-RUBY_EVAL
+          #{name}(halted) do
+            #{code}
+            value
+          end
+          RUBY_EVAL
+        end
+      end
+
+
+      def one_time_conditions_valid?(object)
+        object.send("_one_time_conditions_valid_#{@callback_id}?")
+      end
+
+      private
+
       # Compile around filters with conditions into proxy methods
       # that contain the conditions.
       #
@@ -197,6 +213,7 @@ module ActiveSupport
       #   end
       # end
       #
+      def define_conditional_callback
         name = "_conditional_callback_#{@kind}_#{next_id}"
         @klass.class_eval <<-RUBY_EVAL,  __FILE__, __LINE__ + 1
           def #{name}(halted)
@@ -209,32 +226,8 @@ module ActiveSupport
            end
          end
         RUBY_EVAL
-          "#{name}(halted) do"
+        name
       end
-      end
-
-      # This will supply contents for around and after filters, but not
-      # before filters (for the backward pass).
-      def end(key=nil, object=nil)
-        return if key && !object.send("_one_time_conditions_valid_#{@callback_id}?")
-
-        case @kind
-        when :after
-          # after_save :filter_name, :if => :condition
-          <<-RUBY_EVAL
-          if #{@compiled_options}
-            #{@filter}
-          end
-          RUBY_EVAL
-        when :around
-          <<-RUBY_EVAL
-            value
-          end
-          RUBY_EVAL
-        end
-      end
-
-      private
 
       # Options support the same options as filters themselves (and support
       # symbols, string, procs, and objects), so compile a conditional
@@ -338,10 +331,20 @@ module ActiveSupport
         method << "value = nil"
         method << "halted = false"
 
-        each do |callback|
+        callbacks = yielding
-          method << callback.start(key, object)
+        applicable_callbacks_for(key, object).reverse_each do |callback|
+          callbacks = callback.apply(callbacks, key, object)
+        end
+        method << callbacks
+
+        method << "raise rescued_error if rescued_error" if config[:rescuable]
+        method << "halted ? false : (block_given? ? value : true)"
+        method.flatten.compact.join("\n")
       end
 
+      # Returns part of method that evaluates the callback block
+      def yielding
+        method = []
         if config[:rescuable]
           method << "rescued_error = nil"
           method << "begin"
@@ -354,14 +357,15 @@ module ActiveSupport
           method << "rescued_error = e"
           method << "end"
         end
-
+        method.join("\n")
-        reverse_each do |callback|
-          method << callback.end(key, object)
       end
 
-        method << "raise rescued_error if rescued_error" if config[:rescuable]
+      # Selects callbacks that have valid <tt>:per_key</tt> condition
-        method << "halted ? false : (block_given? ? value : true)"
+      def applicable_callbacks_for(key, object)
-        method.compact.join("\n")
+        return self unless key
+        select do |callback|
+          callback.one_time_conditions_valid?(object)
+        end
       end
     end