kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Merge pull request #26258 from kamipo/remove_unnecessary_format_string

Browse source 
Remove unnecessary `format_string`
This commit is contained in:
Rafael França 2016-08-23 22:36:12 -03:00 committed by GitHub
commit 3df9876a24
1 changed files with 2 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
activerecord/lib/active_record/schema_dumper.rb
View file

@ -145,22 +145,9 @@ HEADER
# find all migration keys used in this table
keys = @connection.migration_keys
# figure out the lengths for each column based on above keys
lengths = [0] * keys.length
# the string we're going to sprintf our values against, with standardized column widths
format_string = ["%s"] * keys.length
# add column type definition to our format string
format_string.unshift " t.%s "
format_string *= ""
column_specs.each do |colspec|
values = keys.zip(lengths).map { |key, len| colspec.key?(key) ? colspec[key] + ", " : " " * len }
values.unshift colspec[:type]
tbl.print((format_string % values).gsub(/,\s*$/, ""))
tbl.puts
values = keys.map { |key| colspec[key] }.compact
tbl.puts " t.#{colspec[:type]} #{values.join(", ")}"
end
indexes_in_create(table, tbl)