From 49f513c25415f94452af1bb8fe3f55f090a6d0f2 Mon Sep 17 00:00:00 2001 From: Zachary Scott Date: Sat, 28 Sep 2013 19:31:46 -0400 Subject: [PATCH 1/3] fixed a doc bug in the CHANGELOG.md s/does no longer depend on/no longer depends on/ --- activerecord/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/activerecord/CHANGELOG.md b/activerecord/CHANGELOG.md index 810a2c668d..dc549240c2 100644 --- a/activerecord/CHANGELOG.md +++ b/activerecord/CHANGELOG.md @@ -519,7 +519,7 @@ *Neeraj Singh* -* Fixture setup does no longer depend on `ActiveRecord::Base.configurations`. +* Fixture setup no longer depends on `ActiveRecord::Base.configurations`. This is relevant when `ENV["DATABASE_URL"]` is used in place of a `database.yml`. *Yves Senn* From ac53d6e94287c63b5c105bc8a571c593864230c2 Mon Sep 17 00:00:00 2001 From: Zachary Scott Date: Sat, 28 Sep 2013 19:32:48 -0400 Subject: [PATCH 2/3] Use ActiveRecord::Base#update! instead of #update_attributes! --- guides/source/action_controller_overview.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guides/source/action_controller_overview.md b/guides/source/action_controller_overview.md index 8dfecd0190..cd4a1a0792 100644 --- a/guides/source/action_controller_overview.md +++ b/guides/source/action_controller_overview.md @@ -209,7 +209,7 @@ class PeopleController < ActionController::Base # Request reply. def update person = current_account.people.find(params[:id]) - person.update_attributes!(person_params) + person.update!(person_params) redirect_to person end From e9a1ecd583f3993c696a1cc95e182dcbe346553b Mon Sep 17 00:00:00 2001 From: Vijay Dev Date: Tue, 15 Oct 2013 23:27:34 +0530 Subject: [PATCH 3/3] Revert "fixed a doc bug in the CHANGELOG.md s/does no longer depend on/no longer depends on/" This reverts commit 49f513c25415f94452af1bb8fe3f55f090a6d0f2. Reason: Changelogs aren't supposed to be edited in docrails. --- activerecord/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/activerecord/CHANGELOG.md b/activerecord/CHANGELOG.md index dc549240c2..810a2c668d 100644 --- a/activerecord/CHANGELOG.md +++ b/activerecord/CHANGELOG.md @@ -519,7 +519,7 @@ *Neeraj Singh* -* Fixture setup no longer depends on `ActiveRecord::Base.configurations`. +* Fixture setup does no longer depend on `ActiveRecord::Base.configurations`. This is relevant when `ENV["DATABASE_URL"]` is used in place of a `database.yml`. *Yves Senn*