Merge pull request #8465 from frodsan/update_am_action_callbacks

use _action callbacks in actionmailer

actionmailer/lib/action_mailer/base.rb

@@ -284,12 +284,12 @@ module ActionMailer
   #
   # = Callbacks
   #
-  # You can specify callbacks using before_filter and after_filter for configuring your messages.
+  # You can specify callbacks using before_action and after_action for configuring your messages.
   # This may be useful, for example, when you want to add default inline attachments for all
   # messages sent out by a certain mailer class:
   #
   #   class Notifier < ActionMailer::Base
-  #     before_filter :add_inline_attachment!
+  #     before_action :add_inline_attachment!
   #
   #     def welcome
   #       mail
@@ -306,8 +306,8 @@ module ActionMailer
   # can define and configure callbacks in the same manner that you would use callbacks in
   # classes that inherit from ActionController::Base.
   #
-  # Note that unless you have a specific reason to do so, you should prefer using before_filter
+  # Note that unless you have a specific reason to do so, you should prefer using before_action
-  # rather than after_filter in your ActionMailer classes so that headers are parsed properly.
+  # rather than after_action in your ActionMailer classes so that headers are parsed properly.
   #
   # = Configuration options
   #

actionmailer/test/base_test.rb

@@ -584,9 +584,9 @@ class BaseTest < ActiveSupport::TestCase
     assert_equal("Thanks for signing up this afternoon", mail.subject)
   end
 
-  test "modifying the mail message with a before_filter" do
+  test "modifying the mail message with a before_action" do
-    class BeforeFilterMailer < ActionMailer::Base
+    class BeforeActionMailer < ActionMailer::Base
-      before_filter :add_special_header!
+      before_action :add_special_header!
 
       def welcome ; mail ; end
 
@@ -596,12 +596,12 @@ class BaseTest < ActiveSupport::TestCase
       end
     end
 
-    assert_equal('Wow, so special', BeforeFilterMailer.welcome['X-Special-Header'].to_s)
+    assert_equal('Wow, so special', BeforeActionMailer.welcome['X-Special-Header'].to_s)
   end
 
-  test "modifying the mail message with an after_filter" do
+  test "modifying the mail message with an after_action" do
-    class AfterFilterMailer < ActionMailer::Base
+    class AfterActionMailer < ActionMailer::Base
-      after_filter :add_special_header!
+      after_action :add_special_header!
 
       def welcome ; mail ; end
 
@@ -611,12 +611,12 @@ class BaseTest < ActiveSupport::TestCase
       end
     end
 
-    assert_equal('Testing', AfterFilterMailer.welcome['X-Special-Header'].to_s)
+    assert_equal('Testing', AfterActionMailer.welcome['X-Special-Header'].to_s)
   end
 
-  test "adding an inline attachment using a before_filter" do
+  test "adding an inline attachment using a before_action" do
     class DefaultInlineAttachmentMailer < ActionMailer::Base
-      before_filter :add_inline_attachment!
+      before_action :add_inline_attachment!
 
       def welcome ; mail ; end
 

actionpack/test/controller/default_url_options_with_before_action_test.rb

@@ -1,10 +1,10 @@
 require 'abstract_unit'
 
 
-class ControllerWithBeforeFilterAndDefaultUrlOptions < ActionController::Base
+class ControllerWithBeforeActionAndDefaultUrlOptions < ActionController::Base
 
-  before_filter { I18n.locale = params[:locale] }
+  before_action { I18n.locale = params[:locale] }
-  after_filter { I18n.locale = "en" }
+  after_action { I18n.locale = "en" }
 
   def target
     render :text => "final response"
@@ -19,11 +19,11 @@ class ControllerWithBeforeFilterAndDefaultUrlOptions < ActionController::Base
   end
 end
 
-class ControllerWithBeforeFilterAndDefaultUrlOptionsTest < ActionController::TestCase
+class ControllerWithBeforeActionAndDefaultUrlOptionsTest < ActionController::TestCase
 
   # This test has its roots in issue #1872
   test "should redirect with correct locale :de" do
     get :redirect, :locale => "de"
-    assert_redirected_to "/controller_with_before_filter_and_default_url_options/target?locale=de"
+    assert_redirected_to "/controller_with_before_action_and_default_url_options/target?locale=de"
   end
 end