kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Merge pull request #40173 from p8/shorten-inspect-on-request

Browse source 
Shorten inspect on ActionDispatch::Request
This commit is contained in:
Kasper Timm Hansen 2020-09-05 20:29:31 +02:00 committed by GitHub
commit 451c3c0a1b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 18 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
actionpack/lib/action_dispatch/http/request.rb
View file

@ -431,6 +431,10 @@ module ActionDispatch
super || scheme == "wss"
end
def inspect # :nodoc:
"#<#{self.class.name} #{method} #{original_url.dump} for #{remote_ip}>"
end
private
def check_method(name)
HTTP_METHOD_LOOKUP[name] || raise(ActionController::UnknownHttpMethod, "#{name}, accepted HTTP methods are #{HTTP_METHODS[0...-1].join(', ')}, and #{HTTP_METHODS[-1]}")

14
actionpack/test/dispatch/request_test.rb
View file

@ -1290,3 +1290,17 @@ class EarlyHintsRequestTest < BaseRequestTest
assert_equal expected_hints, early_hints
end
end
class RequestInspectTest < BaseRequestTest
test "inspect" do
request = stub_request(
"REQUEST_METHOD" => "POST",
"REMOTE_ADDR" => "1.2.3.4",
"HTTP_X_FORWARDED_PROTO" => "https",
"HTTP_X_FORWARDED_HOST" => "example.com:443",
"PATH_INFO" => "/path/",
"QUERY_STRING" => "q=1"
)
assert_match %r(#<ActionDispatch::Request POST "https://example.com/path/\?q=1" for 1.2.3.4>), request.inspect
end
end