kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Remove deprecated ActiveRecord::ConnectionAdapters::SQLite3Adapter#valid_alter_table_type?

Browse source
This commit is contained in:
Rafael Mendonça França 2019-01-14 22:28:57 -05:00
parent 91ddb30083
commit 45b4d5f81f
No known key found for this signature in database
GPG key ID: FC23B6D0F1EEE948
3 changed files with 4 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
activerecord/CHANGELOG.md
View file

@ -1,3 +1,7 @@
* Remove deprecated `ActiveRecord::ConnectionAdapters::SQLite3Adapter#valid_alter_table_type?`.
*Rafael Mendonça França*
* Do not allow passing the column name to `sum` when a block is passed.
*Rafael Mendonça França*

5
activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb
View file

@ -307,11 +307,6 @@ module ActiveRecord
rename_table_indexes(table_name, new_name)
end
def valid_alter_table_type?(type, options = {})
!invalid_alter_table_type?(type, options)
end
deprecate :valid_alter_table_type?
def add_column(table_name, column_name, type, options = {}) #:nodoc:
if invalid_alter_table_type?(type, options)
alter_table(table_name) do |definition|

4
activerecord/test/cases/adapters/sqlite3/sqlite3_adapter_test.rb
View file

@ -536,10 +536,6 @@ module ActiveRecord
end
end
def test_deprecate_valid_alter_table_type
assert_deprecated { @conn.valid_alter_table_type?(:string) }
end
def test_db_is_not_readonly_when_readonly_option_is_false
conn = Base.sqlite3_connection database: ":memory:",
adapter: "sqlite3",