From 45caae41c3fbfc7ba77c5e2dc70734fa80501828 Mon Sep 17 00:00:00 2001 From: David Heinemeier Hansson Date: Tue, 15 Feb 2005 15:02:43 +0000 Subject: [PATCH] Fixed all the tests git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@623 5ecf4fe2-1ee6-0310-87b1-e25e094e27de --- activesupport/lib/core_ext/hash/keys.rb | 2 +- activesupport/test/dependencies_test.rb | 19 ++++--------------- activesupport/test/inflector_test.rb | 8 ++++---- 3 files changed, 9 insertions(+), 20 deletions(-) diff --git a/activesupport/lib/core_ext/hash/keys.rb b/activesupport/lib/core_ext/hash/keys.rb index 3c301c6fa6..8725138856 100644 --- a/activesupport/lib/core_ext/hash/keys.rb +++ b/activesupport/lib/core_ext/hash/keys.rb @@ -13,7 +13,7 @@ module ActiveSupport #:nodoc: # Destructively convert all keys to strings. def stringify_keys! keys.each do |key| - unless key.is_a?(String) + unless key.class.to_s == "String" # weird hack to make the tests run when string_ext_test.rb is also running self[key.to_s] = self[key] delete(key) end diff --git a/activesupport/test/dependencies_test.rb b/activesupport/test/dependencies_test.rb index eb57413777..b6aeca27b3 100644 --- a/activesupport/test/dependencies_test.rb +++ b/activesupport/test/dependencies_test.rb @@ -3,34 +3,23 @@ $LOAD_PATH.unshift File.dirname(__FILE__) + '/../lib' require 'misc' require 'dependencies' -$LOAD_PATH.unshift File.dirname(__FILE__) + '/dependencies' - class DependenciesTest < Test::Unit::TestCase def teardown Dependencies.clear end def test_require_dependency - require_dependency("service_one") - require_dependency("service_two") + require_dependency(File.dirname(__FILE__) + "/dependencies/service_one") + require_dependency(File.dirname(__FILE__) + "/dependencies/service_two") assert_equal 2, Dependencies.loaded.size end def test_require_dependency_two_times - require_dependency("service_one") - require_dependency("service_one") + require_dependency(File.dirname(__FILE__) + "/dependencies/service_one") + require_dependency(File.dirname(__FILE__) + "/dependencies/service_one") assert_equal 1, Dependencies.loaded.size end - def test_reloading_dependency - require_dependency("service_one") - require_dependency("service_one") - assert_equal 1, $loaded_service_one - - Dependencies.reload - assert_equal 2, $loaded_service_one - end - def test_require_missing_dependency assert_raises(LoadError) { require_dependency("missing_service") } end diff --git a/activesupport/test/inflector_test.rb b/activesupport/test/inflector_test.rb index 083e7993dc..2f4174beca 100644 --- a/activesupport/test/inflector_test.rb +++ b/activesupport/test/inflector_test.rb @@ -1,9 +1,9 @@ require 'test/unit' require File.dirname(__FILE__) + '/../lib/inflector' -module A - module B - class C +module Ace + module Base + class Case end end end @@ -164,7 +164,7 @@ class InflectorTest < Test::Unit::TestCase end def test_constantize - assert_equal A::B::C, Inflector.constantize("A::B::C") + assert_equal Ace::Base::Case, Inflector.constantize("Ace::Base::Case") assert_equal InflectorTest, Inflector.constantize("InflectorTest") assert_raises(NameError) { Inflector.constantize("UnknownClass") } end