From 46cb45df485d6f4d67a8e448a142bcab47fc0f2a Mon Sep 17 00:00:00 2001 From: Kasper Timm Hansen Date: Thu, 25 Feb 2016 11:13:42 +0100 Subject: [PATCH] Additional review of 6b31761. * Fixes typos in error message and release notes. * Removes unused template test file. --- actionpack/lib/action_controller/metal/implicit_render.rb | 2 +- .../fixtures/implicit_render_test/some_action_2.html+zomg.erb | 1 - guides/source/5_0_release_notes.md | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) delete mode 100644 actionpack/test/fixtures/implicit_render_test/some_action_2.html+zomg.erb diff --git a/actionpack/lib/action_controller/metal/implicit_render.rb b/actionpack/lib/action_controller/metal/implicit_render.rb index 1f0179a287..6b540d42c7 100644 --- a/actionpack/lib/action_controller/metal/implicit_render.rb +++ b/actionpack/lib/action_controller/metal/implicit_render.rb @@ -37,7 +37,7 @@ module ActionController if template_exists?(action_name.to_s, _prefixes, variants: request.variant) render(*args) elsif any_templates?(action_name.to_s, _prefixes) - message = "#{self.class.name}\##{action_name} does not know how to repond " \ + message = "#{self.class.name}\##{action_name} does not know how to respond " \ "to this request. There are other templates available for this controller " \ "action but none of them were suitable for this request.\n\n" \ "This usually happens when the client requested an unsupported format " \ diff --git a/actionpack/test/fixtures/implicit_render_test/some_action_2.html+zomg.erb b/actionpack/test/fixtures/implicit_render_test/some_action_2.html+zomg.erb deleted file mode 100644 index 7d8187321c..0000000000 --- a/actionpack/test/fixtures/implicit_render_test/some_action_2.html+zomg.erb +++ /dev/null @@ -1 +0,0 @@ -zomg diff --git a/guides/source/5_0_release_notes.md b/guides/source/5_0_release_notes.md index 52dbe78563..dc631e5cb9 100644 --- a/guides/source/5_0_release_notes.md +++ b/guides/source/5_0_release_notes.md @@ -257,7 +257,7 @@ Please refer to the [Changelog][action-pack] for detailed changes. ([Pull Request](https://github.com/rails/rails/pull/17573)) * Controller actions without an explicit `render` call and with no - corresponding templates will render `head :no_conten` implicitly + corresponding templates will render `head :no_content` implicitly instead of raising an error. (Pull Request [1](https://github.com/rails/rails/pull/19377), [2](https://github.com/rails/rails/pull/23827))