From 47f545913819561b43a2716bb462bba04ca475a5 Mon Sep 17 00:00:00 2001 From: Akira Matsuda Date: Tue, 15 Sep 2020 10:18:40 +0900 Subject: [PATCH] Module#const_set is a public method --- actionmailbox/test/generators/mailbox_generator_test.rb | 2 +- actionview/test/active_record_unit.rb | 2 +- .../cases/connection_adapters/connection_handler_test.rb | 2 +- activerecord/test/cases/modules_test.rb | 2 +- railties/test/generators/controller_generator_test.rb | 2 +- railties/test/generators/mailer_generator_test.rb | 6 +++--- .../test/generators/scaffold_controller_generator_test.rb | 2 +- 7 files changed, 9 insertions(+), 9 deletions(-) diff --git a/actionmailbox/test/generators/mailbox_generator_test.rb b/actionmailbox/test/generators/mailbox_generator_test.rb index 9ffa73321b..f9677ba591 100644 --- a/actionmailbox/test/generators/mailbox_generator_test.rb +++ b/actionmailbox/test/generators/mailbox_generator_test.rb @@ -49,7 +49,7 @@ class MailboxGeneratorTest < Rails::Generators::TestCase end def test_check_class_collision - Object.send :const_set, :InboxMailbox, Class.new + Object.const_set :InboxMailbox, Class.new content = capture(:stderr) { run_generator } assert_match(/The name 'InboxMailbox' is either already used in your application or reserved/, content) ensure diff --git a/actionview/test/active_record_unit.rb b/actionview/test/active_record_unit.rb index 4efb31a360..20f6a9217a 100644 --- a/actionview/test/active_record_unit.rb +++ b/actionview/test/active_record_unit.rb @@ -58,7 +58,7 @@ class ActiveRecordTestConnector ActiveRecord::Base.configurations = { "sqlite3_ar_integration" => options } ActiveRecord::Base.connection - Object.send(:const_set, :QUOTED_TYPE, ActiveRecord::Base.connection.quote_column_name("type")) unless Object.const_defined?(:QUOTED_TYPE) + Object.const_set :QUOTED_TYPE, ActiveRecord::Base.connection.quote_column_name("type") unless Object.const_defined?(:QUOTED_TYPE) else raise "Can't setup connection since ActiveRecord isn't loaded." end diff --git a/activerecord/test/cases/connection_adapters/connection_handler_test.rb b/activerecord/test/cases/connection_adapters/connection_handler_test.rb index 03e39f1684..06bafeef1e 100644 --- a/activerecord/test/cases/connection_adapters/connection_handler_test.rb +++ b/activerecord/test/cases/connection_adapters/connection_handler_test.rb @@ -253,7 +253,7 @@ module ActiveRecord end def test_connection_specification_name_should_fallback_to_parent - Object.send :const_set, :ApplicationRecord, ApplicationRecord + Object.const_set :ApplicationRecord, ApplicationRecord klassA = Class.new(Base) klassB = Class.new(klassA) diff --git a/activerecord/test/cases/modules_test.rb b/activerecord/test/cases/modules_test.rb index 87455e4fcb..842de49fcd 100644 --- a/activerecord/test/cases/modules_test.rb +++ b/activerecord/test/cases/modules_test.rb @@ -24,7 +24,7 @@ class ModulesTest < ActiveRecord::TestCase teardown do # reinstate the constants that we undefined in the setup @undefined_consts.each do |constant, value| - Object.send :const_set, constant, value unless value.nil? + Object.const_set constant, value unless value.nil? end ActiveRecord::Base.store_full_sti_class = true diff --git a/railties/test/generators/controller_generator_test.rb b/railties/test/generators/controller_generator_test.rb index ae327ad801..bfd553ac2a 100644 --- a/railties/test/generators/controller_generator_test.rb +++ b/railties/test/generators/controller_generator_test.rb @@ -20,7 +20,7 @@ class ControllerGeneratorTest < Rails::Generators::TestCase end def test_check_class_collision - Object.send :const_set, :ObjectController, Class.new + Object.const_set :ObjectController, Class.new content = capture(:stderr) { run_generator ["object"] } assert_match(/The name 'ObjectController' is either already used in your application or reserved/, content) ensure diff --git a/railties/test/generators/mailer_generator_test.rb b/railties/test/generators/mailer_generator_test.rb index 099e06c4d3..4498e1ae23 100644 --- a/railties/test/generators/mailer_generator_test.rb +++ b/railties/test/generators/mailer_generator_test.rb @@ -31,7 +31,7 @@ class MailerGeneratorTest < Rails::Generators::TestCase end def test_check_class_collision - Object.send :const_set, :NotifierMailer, Class.new + Object.const_set :NotifierMailer, Class.new content = capture(:stderr) { run_generator } assert_match(/The name 'NotifierMailer' is either already used in your application or reserved/, content) ensure @@ -60,7 +60,7 @@ class MailerGeneratorTest < Rails::Generators::TestCase end def test_check_test_class_collision - Object.send :const_set, :NotifierMailerTest, Class.new + Object.const_set :NotifierMailerTest, Class.new content = capture(:stderr) { run_generator } assert_match(/The name 'NotifierMailerTest' is either already used in your application or reserved/, content) ensure @@ -68,7 +68,7 @@ class MailerGeneratorTest < Rails::Generators::TestCase end def test_check_preview_class_collision - Object.send :const_set, :NotifierMailerPreview, Class.new + Object.const_set :NotifierMailerPreview, Class.new content = capture(:stderr) { run_generator } assert_match(/The name 'NotifierMailerPreview' is either already used in your application or reserved/, content) ensure diff --git a/railties/test/generators/scaffold_controller_generator_test.rb b/railties/test/generators/scaffold_controller_generator_test.rb index cdf6e34ee4..c2f18cb527 100644 --- a/railties/test/generators/scaffold_controller_generator_test.rb +++ b/railties/test/generators/scaffold_controller_generator_test.rb @@ -323,7 +323,7 @@ class ScaffoldControllerGeneratorTest < Rails::Generators::TestCase end def test_check_class_collision - Object.send :const_set, :UsersController, Class.new + Object.const_set :UsersController, Class.new content = capture(:stderr) { run_generator } assert_match(/The name 'UsersController' is either already used in your application or reserved/, content) ensure