From 4e66e2dffc609aaebc8db2e359e381ecbce55b95 Mon Sep 17 00:00:00 2001 From: John Crepezzi Date: Wed, 25 Sep 2019 12:53:52 -0400 Subject: [PATCH] Update test to avoid Puma output format change We are seeing some test failures for this test in #37291. It looks like what's going on is that Puma has changed the output for this command between 4.1 and 4.2 Previously: ``` ... * Environment: development * Listening on tcp://localhost:3000 ... ``` Now: ``` ... * Environment: development * Listening on tcp://127.0.0.1:3000 * Listening on tcp://[::1]:3000 ... ``` So to get around this, instead of checking the binding address, just check for the presence of 'Listening' generally like we do on server start. Co-authored-by: eileencodes --- railties/test/application/server_test.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/railties/test/application/server_test.rb b/railties/test/application/server_test.rb index 5fe1b4e6e7..c7aec8d601 100644 --- a/railties/test/application/server_test.rb +++ b/railties/test/application/server_test.rb @@ -36,7 +36,7 @@ module ApplicationTests rails("restart") assert_output("Restarting", primary) - assert_output("tcp://localhost:3000", primary) + assert_output("Listening", primary) ensure kill(pid) if pid end