Changed the auto-timestamping feature to use ActiveRecord::Base.default_timezone instead of entertaining the parallel ActiveRecord::Base.timestamps_gmt method. The latter is now deprecated and will throw a warning on use (but still work) #710 [Jamis Buck]

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@788 5ecf4fe2-1ee6-0310-87b1-e25e094e27de

activerecord/CHANGELOG

@@ -1,5 +1,7 @@
 *SVN*
 
+* Changed the auto-timestamping feature to use ActiveRecord::Base.default_timezone instead of entertaining the parallel ActiveRecord::Base.timestamps_gmt method. The latter is now deprecated and will throw a warning on use (but still work) #710 [Jamis Buck]
+
 * Added a OCI8-based Oracle adapter that has been verified to work with Oracle 8 and 9 #629 [Graham Jenkins]. Usage notes:
 
     1.  Key generation uses a sequence "rails_sequence" for all tables. (I couldn't find a simple

activerecord/lib/active_record/timestamp.rb

@@ -19,7 +19,7 @@ module ActiveRecord
     end    
       
     def create_with_timestamps #:nodoc:
-      t = timestamps_gmt ? Time.now.gmtime : Time.now
+      t = ( self.class.default_timezone == :utc ? Time.now.utc : Time.now )
       write_attribute("created_at", t) if record_timestamps && respond_to?(:created_at) && created_at.nil?
       write_attribute("created_on", t) if record_timestamps && respond_to?(:created_on) && created_on.nil?
 
@@ -30,7 +30,7 @@ module ActiveRecord
     end
 
     def update_with_timestamps #:nodoc:
-      t = timestamps_gmt ? Time.now.gmtime : Time.now
+      t = ( self.class.default_timezone == :utc ? Time.now.utc : Time.now )
       write_attribute("updated_at", t) if record_timestamps && respond_to?(:updated_at)
       write_attribute("updated_on", t) if record_timestamps && respond_to?(:updated_on)
 
@@ -44,7 +44,17 @@ module ActiveRecord
     # if the table has columns of either of these names. This feature is turned on by default.
     @@record_timestamps = true
     cattr_accessor :record_timestamps
+
+    # deprecated: use ActiveRecord::Base.default_timezone instead.
     @@timestamps_gmt = false
-    cattr_accessor :timestamps_gmt
+    def self.timestamps_gmt=( gmt ) #:nodoc:
+      warn "timestamps_gmt= is deprecated. use default_timezone= instead"
+      self.default_timezone = ( gmt ? :utc : :local )
+    end
+
+    def self.timestamps_gmt #:nodoc:
+      warn "timestamps_gmt is deprecated. use default_timezone instead"
+      self.default_timezone == :utc
+    end
   end
 end

activerecord/test/base_test.rb

@@ -709,13 +709,13 @@ class BasicsTest < Test::Unit::TestCase
 
   def test_define_attr_method_with_value
     k = Class.new( ActiveRecord::Base )
-    k.define_attr_method :table_name, "foo"
+    k.send(:define_attr_method, :table_name, "foo")
     assert_equal "foo", k.table_name
   end
 
   def test_define_attr_method_with_block
     k = Class.new( ActiveRecord::Base )
-    k.define_attr_method( :primary_key ) { "sys_" + original_primary_key }
+    k.send(:define_attr_method, :primary_key) { "sys_" + original_primary_key }
     assert_equal "sys_id", k.primary_key
   end