kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Merge pull request #43 from dixpac/small_gcs_service_refactoring

Browse source 
Remove unnecessary variables from gcs_service implementation
This commit is contained in:
George Claghorn 2017-07-13 14:54:30 -04:00 committed by GitHub
commit 50bec56254
1 changed files with 2 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
lib/active_storage/service/gcs_service.rb
View file

@ -36,20 +36,14 @@ class ActiveStorage::Service::GCSService < ActiveStorage::Service
def exist?(key)
instrument :exist, key do |payload|
answer = file_for(key).present?
payload[:exist] = answer
answer
payload[:exist] = file_for(key).present?
end
end
def url(key, expires_in:, disposition:, filename:)
instrument :url, key do |payload|
query = { "response-content-disposition" => "#{disposition}; filename=\"#{filename}\"" }
generated_url = file_for(key).signed_url(expires: expires_in, query: query)
payload[:url] = generated_url
generated_url
payload[:url] = file_for(key).signed_url(expires: expires_in, query: query)
end
end