kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Fix random CI failure due to non-deterministic sorting order

Browse source 
An `author` has a lots of `posts` in the fixtures, so the result of
`author.post` and finding a `post` by `author_id` is non-deterministic.

https://travis-ci.org/rails/rails/jobs/504332292#L1202-L1208
This commit is contained in:
Ryuta Kamizono 2019-03-11 03:48:53 +09:00
parent 260a3c6512
commit 50e01ec01a
1 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
activerecord/test/cases/finder_test.rb
View file

@ -3,6 +3,7 @@
require "cases/helper" require "cases/helper"
require "models/post" require "models/post"
require "models/author" require "models/author"
require "models/account"
require "models/categorization" require "models/categorization"
require "models/comment" require "models/comment"
require "models/company" require "models/company"
@ -461,14 +462,14 @@ class FinderTest < ActiveRecord::TestCase
end end
def test_find_by_association_subquery def test_find_by_association_subquery
author = authors(:david) firm = companies(:first_firm)
assert_equal author.post, Post.find_by(author: Author.where(id: author)) assert_equal firm.account, Account.find_by(firm: Firm.where(id: firm))
assert_equal author.post, Post.find_by(author_id: Author.where(id: author)) assert_equal firm.account, Account.find_by(firm_id: Firm.where(id: firm))
end end
def test_find_by_and_where_consistency_with_active_record_instance def test_find_by_and_where_consistency_with_active_record_instance
author = authors(:david) firm = companies(:first_firm)
assert_equal Post.where(author_id: author).take, Post.find_by(author_id: author) assert_equal Account.where(firm_id: firm).take, Account.find_by(firm_id: firm)
end end
def test_take def test_take