kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Verify direct upload checksums

Browse source 
Closes #74.
This commit is contained in:
George Claghorn 2017-07-24 12:41:34 -04:00
parent 69922fc715
commit 52eed68e39
6 changed files with 18 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/models/active_storage/blob.rb
View file

@ -61,7 +61,7 @@ class ActiveStorage::Blob < ActiveRecord::Base
end
def url_for_direct_upload(expires_in: 5.minutes)
service.url_for_direct_upload key, expires_in: expires_in, content_type: content_type, content_length: byte_size
service.url_for_direct_upload key, expires_in: expires_in, content_type: content_type, content_length: byte_size, checksum: checksum
end

2
lib/active_storage/service.rb
View file

@ -78,7 +78,7 @@ class ActiveStorage::Service
raise NotImplementedError
end
def url_for_direct_upload(key, expires_in:, content_type:, content_length:)
def url_for_direct_upload(key, expires_in:, content_type:, content_length:, checksum:)
raise NotImplementedError
end

6
lib/active_storage/service/gcs_service.rb
View file

@ -44,7 +44,7 @@ class ActiveStorage::Service::GCSService < ActiveStorage::Service
def url(key, expires_in:, disposition:, filename:, content_type:)
instrument :url, key do |payload|
generated_url = file_for(key).signed_url expires: expires_in, query: {
generated_url = file_for(key).signed_url expires: expires_in, query: {
"response-content-disposition" => "#{disposition}; filename=\"#{filename}\"",
"response-content-type" => content_type
}
@ -55,10 +55,10 @@ class ActiveStorage::Service::GCSService < ActiveStorage::Service
end
end
def url_for_direct_upload(key, expires_in:, content_type:, content_length:)
def url_for_direct_upload(key, expires_in:, content_type:, content_length:, checksum:)
instrument :url, key do |payload|
generated_url = bucket.signed_url key, method: "PUT", expires: expires_in,
content_type: content_type
content_type: content_type, content_md5: checksum
payload[:url] = generated_url

4
lib/active_storage/service/s3_service.rb
View file

@ -59,10 +59,10 @@ class ActiveStorage::Service::S3Service < ActiveStorage::Service
end
end
def url_for_direct_upload(key, expires_in:, content_type:, content_length:)
def url_for_direct_upload(key, expires_in:, content_type:, content_length:, checksum:)
instrument :url, key do |payload|
generated_url = object_for(key).presigned_url :put, expires_in: expires_in,
content_type: content_type, content_length: content_length
content_type: content_type, content_length: content_length, content_md5: checksum
payload[:url] = generated_url

11
test/service/gcs_service_test.rb
View file

@ -9,14 +9,15 @@ if SERVICE_CONFIGURATIONS[:gcs]
test "direct upload" do
begin
key = SecureRandom.base58(24)
data = "Something else entirely!"
direct_upload_url = @service.url_for_direct_upload(key, expires_in: 5.minutes, content_type: "text/plain", content_length: data.size)
key = SecureRandom.base58(24)
data = "Something else entirely!"
checksum = Digest::MD5.base64digest(data)
url = @service.url_for_direct_upload(key, expires_in: 5.minutes, content_type: "text/plain", content_length: data.size, checksum: checksum)
HTTParty.put(
direct_upload_url,
url,
body: data,
headers: { "Content-Type" => "text/plain" },
headers: { "Content-Type" => "text/plain", "Content-MD5" => checksum },
debug_output: STDOUT
)

9
test/service/s3_service_test.rb
View file

@ -9,14 +9,15 @@ if SERVICE_CONFIGURATIONS[:s3]
test "direct upload" do
begin
key = SecureRandom.base58(24)
data = "Something else entirely!"
url = @service.url_for_direct_upload(key, expires_in: 5.minutes, content_type: "text/plain", content_length: data.size)
key = SecureRandom.base58(24)
data = "Something else entirely!"
checksum = Digest::MD5.base64digest(data)
url = @service.url_for_direct_upload(key, expires_in: 5.minutes, content_type: "text/plain", content_length: data.size, checksum: checksum)
HTTParty.put(
url,
body: data,
headers: { "Content-Type" => "text/plain" },
headers: { "Content-Type" => "text/plain", "Content-MD5" => checksum },
debug_output: STDOUT
)