From 532ef0d13c8b718665899fc372fbc60732e5ec1e Mon Sep 17 00:00:00 2001 From: Jean Boussier Date: Mon, 6 Sep 2021 16:24:37 +0200 Subject: [PATCH] Add back Lint/UselessAssignment Fix: #43169 --- .rubocop.yml | 3 +++ .../lib/generators/action_text/install/install_generator.rb | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.rubocop.yml b/.rubocop.yml index d92b9a9f77..5ad6a39673 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -221,6 +221,9 @@ Lint/RedundantStringCoercion: Lint/UriEscapeUnescape: Enabled: true +Lint/UselessAssignment: + Enabled: true + Lint/DeprecatedClassMethods: Enabled: true diff --git a/actiontext/lib/generators/action_text/install/install_generator.rb b/actiontext/lib/generators/action_text/install/install_generator.rb index f86f23eaa0..b6b3218df0 100644 --- a/actiontext/lib/generators/action_text/install/install_generator.rb +++ b/actiontext/lib/generators/action_text/install/install_generator.rb @@ -9,7 +9,7 @@ module ActionText source_root File.expand_path("templates", __dir__) def install_javascript_dependencies - if using_node = Pathname(destination_root).join("package.json").exist? + if Pathname(destination_root).join("package.json").exist? say "Installing JavaScript dependencies", :green run "yarn add @rails/actiontext trix" end