mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
Remove 'size' attribute from number_field form helper fixes #3454
f.number_field generates <input type="number", size="30"../> which is invalid HTML5. See: http://dev.w3.org/html5/spec/Overview.html#number-state
This commit is contained in:
parent
533a9f84b0
commit
56207a3f01
2 changed files with 4 additions and 2 deletions
|
@ -1027,6 +1027,8 @@ module ActionView
|
||||||
|
|
||||||
def to_number_field_tag(field_type, options = {})
|
def to_number_field_tag(field_type, options = {})
|
||||||
options = options.stringify_keys
|
options = options.stringify_keys
|
||||||
|
options['size'] ||= nil
|
||||||
|
|
||||||
if range = options.delete("in") || options.delete("within")
|
if range = options.delete("in") || options.delete("within")
|
||||||
options.update("min" => range.min, "max" => range.max)
|
options.update("min" => range.min, "max" => range.max)
|
||||||
end
|
end
|
||||||
|
|
|
@ -438,12 +438,12 @@ class FormHelperTest < ActionView::TestCase
|
||||||
end
|
end
|
||||||
|
|
||||||
def test_number_field
|
def test_number_field
|
||||||
expected = %{<input name="order[quantity]" size="30" max="9" id="order_quantity" type="number" min="1" />}
|
expected = %{<input name="order[quantity]" max="9" id="order_quantity" type="number" min="1" />}
|
||||||
assert_dom_equal(expected, number_field("order", "quantity", :in => 1...10))
|
assert_dom_equal(expected, number_field("order", "quantity", :in => 1...10))
|
||||||
end
|
end
|
||||||
|
|
||||||
def test_range_input
|
def test_range_input
|
||||||
expected = %{<input name="hifi[volume]" step="0.1" size="30" max="11" id="hifi_volume" type="range" min="0" />}
|
expected = %{<input name="hifi[volume]" step="0.1" max="11" id="hifi_volume" type="range" min="0" />}
|
||||||
assert_dom_equal(expected, range_field("hifi", "volume", :in => 0..11, :step => 0.1))
|
assert_dom_equal(expected, range_field("hifi", "volume", :in => 0..11, :step => 0.1))
|
||||||
end
|
end
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue