kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Revert "Merge pull request #18003 from sikachu/permit_all_parameters-thread-safety"

Browse source 
This reverts commit da5cc10e94.

Fixes #18091

See also https://github.com/rails/rails/pull/18003#commitcomment-9030909
This commit is contained in:
Godfrey Chan 2014-12-19 01:14:26 -08:00
parent 65faa8f0da
commit 5923ee6fe0
1 changed files with 6 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
actionpack/lib/action_controller/metal/strong_parameters.rb
View file

@ -92,7 +92,11 @@ module ActionController
# params.permit(:c)
# # => ActionController::UnpermittedParameters: found unpermitted keys: a, b
#
# <tt>ActionController::Parameters</tt> is inherited from
# Please note that these options *are not thread-safe*. In a multi-threaded
# environment they should only be set once at boot-time and never mutated at
# runtime.
#
# <tt>ActionController::Parameters</tt> inherits from
# <tt>ActiveSupport::HashWithIndifferentAccess</tt>, this means
# that you can fetch values using either <tt>:key</tt> or <tt>"key"</tt>.
#
@ -100,6 +104,7 @@ module ActionController
# params[:key] # => "value"
# params["key"] # => "value"
class Parameters < ActiveSupport::HashWithIndifferentAccess
cattr_accessor :permit_all_parameters, instance_accessor: false
cattr_accessor :action_on_unpermitted_parameters, instance_accessor: false
# By default, never raise an UnpermittedParameters exception if these
@ -122,16 +127,6 @@ module ActionController
always_permitted_parameters
end
# Returns the value of +permit_all_parameters+.
def self.permit_all_parameters
Thread.current[:action_controller_permit_all_parameters]
end
# Sets the value of +permit_all_parameters+.
def self.permit_all_parameters=(value)
Thread.current[:action_controller_permit_all_parameters] = value
end
# Returns a new instance of <tt>ActionController::Parameters</tt>.
# Also, sets the +permitted+ attribute to the default value of
# <tt>ActionController::Parameters.permit_all_parameters</tt>.