kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Add after_save_commit callback as shortcut for after_commit :hook, on: [ :create, :update ]. (#35804)

Browse source
This commit is contained in:
David Heinemeier Hansson 2019-04-02 16:36:07 -07:00 committed by GitHub
parent 798f175c65
commit 59bed68d5e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 24 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
activerecord/CHANGELOG.md
View file

@ -1,3 +1,9 @@
* Add `after_save_commit` callback as shortcut for `after_commit :hook, on: [ :create, :update ]`.
*DHH*
* Add `ActiveRecord::Relation#extract_associated` for extracting associated records from a relation.
* Assign all attributes before calling `build` to ensure the child record is visible in
`before_add` and `after_add` callbacks for `has_many :through` associations.

6
activerecord/lib/active_record/transactions.rb
View file

@ -234,6 +234,12 @@ module ActiveRecord
set_callback(:commit, :after, *args, &block)
end
# Shortcut for <tt>after_commit :hook, on: [ :create, :update ]</tt>.
def after_save_commit(*args, &block)
set_options_for_callbacks!(args, on: [ :create, :update ])
set_callback(:commit, :after, *args, &block)
end
# Shortcut for <tt>after_commit :hook, on: :create</tt>.
def after_create_commit(*args, &block)
set_options_for_callbacks!(args, on: :create)

12
activerecord/test/cases/transaction_callbacks_test.rb
View file

@ -38,6 +38,7 @@ class TransactionCallbacksTest < ActiveRecord::TestCase
before_commit { |record| record.do_before_commit(nil) }
after_commit { |record| record.do_after_commit(nil) }
after_save_commit { |record| record.do_after_commit(:save) }
after_create_commit { |record| record.do_after_commit(:create) }
after_update_commit { |record| record.do_after_commit(:update) }
after_destroy_commit { |record| record.do_after_commit(:destroy) }
@ -110,6 +111,17 @@ class TransactionCallbacksTest < ActiveRecord::TestCase
assert_equal [:after_commit], @first.history
end
def test_only_call_after_commit_on_save_after_transaction_commits_for_saving_record
record = TopicWithCallbacks.new(title: "New topic", written_on: Date.today)
record.after_commit_block(:save) { |r| r.history << :after_save }
record.save!
assert_equal [:after_save], record.history
record.update!(title: "Another topic")
assert_equal [:after_save, :after_save], record.history
end
def test_only_call_after_commit_on_update_after_transaction_commits_for_existing_record
add_transaction_execution_blocks @first