From 5a14dbf521daa70aeba10f1445c960b8c62467d5 Mon Sep 17 00:00:00 2001 From: Timm Date: Tue, 13 Aug 2013 21:25:55 +0200 Subject: [PATCH] Added related Nokogiri issue link to tests that fail with unknown encoding ASCII-8BIT. --- actionview/test/template/date_helper_test.rb | 8 ++++---- actionview/test/template/form_helper_test.rb | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/actionview/test/template/date_helper_test.rb b/actionview/test/template/date_helper_test.rb index 05900c35e1..5283ed0951 100644 --- a/actionview/test/template/date_helper_test.rb +++ b/actionview/test/template/date_helper_test.rb @@ -2130,8 +2130,8 @@ class DateHelperTest < ActionView::TestCase end def test_time_select_with_html_options_within_fields_for - skip "Pending. Output error: 'unknown encoding ASCII-8BIT' makes Loofah return an empty string" - + skip "Pending. Output error: 'unknown encoding ASCII-8BIT' makes Loofah return an empty string. Related: https://github.com/sparklemotion/nokogiri/issues/553" + @post = Post.new @post.written_on = Time.local(2004, 6, 15, 15, 16, 35) @@ -2369,7 +2369,7 @@ class DateHelperTest < ActionView::TestCase end def test_datetime_select_with_html_options_within_fields_for - skip "Pending. Output error: 'unknown encoding ASCII-8BIT' makes Loofah return an empty string" + skip "Pending. Output error: 'unknown encoding ASCII-8BIT' makes Loofah return an empty string. Related: https://github.com/sparklemotion/nokogiri/issues/553" @post = Post.new @post.updated_at = Time.local(2004, 6, 15, 16, 35) @@ -2621,7 +2621,7 @@ class DateHelperTest < ActionView::TestCase end def test_datetime_select_within_fields_for_with_options_index - skip "Pending. Output error: 'unknown encoding ASCII-8BIT' makes Loofah return an empty string" + skip "Pending. Output error: 'unknown encoding ASCII-8BIT' makes Loofah return an empty string. Related: https://github.com/sparklemotion/nokogiri/issues/553" @post = Post.new @post.updated_at = Time.local(2004, 6, 15, 16, 35) id = 456 diff --git a/actionview/test/template/form_helper_test.rb b/actionview/test/template/form_helper_test.rb index 3e2d01f099..f8aad6f2d3 100644 --- a/actionview/test/template/form_helper_test.rb +++ b/actionview/test/template/form_helper_test.rb @@ -2855,8 +2855,8 @@ class FormHelperTest < ActionView::TestCase end def test_fields_for_with_labelled_builder - skip "Pending. I think that there's an output error: 'unknown encoding ASCII-8BIT' in here, which makes Loofah return an empty string" - + skip "Pending. I think that there's an output error: 'unknown encoding ASCII-8BIT' in here, which makes Loofah return an empty string. Related: https://github.com/sparklemotion/nokogiri/issues/553" + output_buffer = fields_for(:post, @post, builder: LabelledFormBuilder) do |f| concat f.text_field(:title) concat f.text_area(:body)