From 5bd29afeb4d6ddf35f2e00dbbb850e8ce9b3febd Mon Sep 17 00:00:00 2001 From: Kasper Timm Hansen Date: Mon, 10 Feb 2020 01:46:26 +0100 Subject: [PATCH] Skip cookie comma separation test Rack updated the RFC they're adhering to when parsing cookies, now no longer including commas. There's still an open question as mentioned in: https://github.com/rails/rails/issues/38420 However, the resilience test is no longer as well needed as it once was and we can move forward separately. If not, this is easily revertible. --- Gemfile.lock | 4 ++-- actionpack/test/dispatch/request_test.rb | 6 ------ 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index 72e8d67570..dfaeeb6349 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -367,7 +367,7 @@ GEM thor raabro (1.1.6) racc (1.4.16) - rack (2.1.1) + rack (2.2.1) rack-cache (1.10.0) rack (>= 0.4) rack-protection (2.0.7) @@ -609,4 +609,4 @@ DEPENDENCIES websocket-client-simple! BUNDLED WITH - 2.1.2 + 2.1.4 diff --git a/actionpack/test/dispatch/request_test.rb b/actionpack/test/dispatch/request_test.rb index 5b8779c821..d725e171c4 100644 --- a/actionpack/test/dispatch/request_test.rb +++ b/actionpack/test/dispatch/request_test.rb @@ -592,12 +592,6 @@ class RequestCookie < BaseRequestTest request = stub_request("HTTP_COOKIE" => "_session_id=c84ace84796670c052c6ceb2451fb0f2; is_admin=yes") assert_equal "c84ace84796670c052c6ceb2451fb0f2", request.cookies["_session_id"], request.cookies.inspect assert_equal "yes", request.cookies["is_admin"], request.cookies.inspect - - # some Nokia phone browsers omit the space after the semicolon separator. - # some developers have grown accustomed to using comma in cookie values. - request = stub_request("HTTP_COOKIE" => "_session_id=c84ace847,96670c052c6ceb2451fb0f2;is_admin=yes") - assert_equal "c84ace847", request.cookies["_session_id"], request.cookies.inspect - assert_equal "yes", request.cookies["is_admin"], request.cookies.inspect end end