kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Merge pull request #7270 from beerlington/use_exists_for_empty

Browse source 
Changing AR:CollectionAssociation#empty? to use #exists?
This commit is contained in:
Jon Leighton 2012-08-05 08:57:58 -07:00
commit 6126f02cf9
1 changed files with 11 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
activerecord/lib/active_record/associations/collection_association.rb
View file

@ -270,12 +270,20 @@ module ActiveRecord
load_target.size
end
# Returns true if the collection is empty. Equivalent to
# <tt>collection.size.zero?</tt>. If the collection has not been already
# Returns true if the collection is empty.
#
# If the collection has been loaded or the <tt>:counter_sql</tt> option
# is provided, it is equivalent to <tt>collection.size.zero?</tt>. If the
# collection has not been loaded, it is equivalent to
# <tt>collection.exists?</tt>. If the collection has not already been
# loaded and you are going to fetch the records anyway it is better to
# check <tt>collection.length.zero?</tt>.
def empty?
size.zero?
if loaded? || options[:counter_sql]
size.zero?
else
!scope.exists?
end
end
# Returns true if the collections is not empty.