kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Completes 08e6491 in reusing maybe_visit

Browse source 
😓 I don't know why the tests did not fail, but to keep
the same syntax as before, `collector =` is required.

Maybe `visit` changes `collector` in-place, so the result is the
same, but since I'm not sure about the side effects, I think this
PR is needed to. Sorry! 😓
This commit is contained in:
claudiob 2014-10-23 17:35:43 -07:00
parent b72ccd0244
commit 621775361c
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lib/arel/visitors/to_sql.rb
View file

@ -229,9 +229,9 @@ module Arel
def visit_Arel_Nodes_SelectCore o, collector
collector << "SELECT"
maybe_visit o.top, collector
collector = maybe_visit o.top, collector
maybe_visit o.set_quantifier, collector
collector = maybe_visit o.set_quantifier, collector
unless o.projections.empty?
collector << SPACE
@ -265,7 +265,7 @@ module Arel
end
end
maybe_visit o.having, collector
collector = maybe_visit o.having, collector
unless o.windows.empty?
collector << WINDOW