kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Remove vestigial require on ActiveStorage GCSService

Browse source 
The file `filename.rb` as mentioned in `require "active_storage/filename"`
belongs to the `app` folder while GCSService belongs to the lib folder.

Looking at the git blame, it was added in commit ccac681122 (diff-bda6a610ef1575b2c8458c96b7f12578)
where ActiveStorage::Filename was actually used. But it is no longer
required on master and therefore can be removed.

This allows anyone to use GCSService directly without enabling
ActiveStorage engine.
This commit is contained in:
Bibek Shrestha 2018-07-04 17:04:26 -04:00
parent 80a9510b75
commit 637a8cde59
1 changed files with 0 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
activestorage/lib/active_storage/service/gcs_service.rb
View file

@ -6,7 +6,6 @@ require "google/cloud/storage"
require "net/http"
require "active_support/core_ext/object/to_query"
require "active_storage/filename"
module ActiveStorage
# Wraps the Google Cloud Storage as an Active Storage service. See ActiveStorage::Service for the generic API