1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00

Warn about using return inside inline callback blocks [ci skip]

Closes #12981
This commit is contained in:
Godfrey Chan 2013-12-11 04:57:39 -08:00
parent 11c0ef58a6
commit 68abbac2fc

View file

@ -93,6 +93,39 @@ If you application depends on one of these features, you can get them back by
adding the [`activesupport-json_encoder`](https://github.com/rails/activesupport-json_encoder) adding the [`activesupport-json_encoder`](https://github.com/rails/activesupport-json_encoder)
gem to your Gemfile. gem to your Gemfile.
### Usage of `return` within inline callback blocks
Previously, Rails allowed you to `return` from an inline callback block:
```ruby
class ReadOnlyModel < ActiveRecord::Base
before_save { return false }
end
```
This behaviour was never intentionally supported. Due to a change in the internals
of `ActiveSupport::Callbacks`, this is no longer allowed in Rails 4.1. Using a
`return` statement in an inline callback block will cause a `LocalJumpError` to
be raised when the callback is executed. If you need to use `return` statements
in your callbacks, it is recommended that you explicitly define them as methods
and pass the method name as a symbol instead:
```ruby
class ReadOnlyModel < ActiveRecord::Base
before_save :before_save_callback
private
def before_save_callback
return false
end
end
```
This change applies to most places in Rails where callbacks are used, including
Active Record and Active Model callbacks, as well as "filters" in Action
Controller (e.g. `before_action`). See [this pull request](https://github.com/rails/rails/pull/13271)
for more details.
### Methods defined in Active Record fixtures ### Methods defined in Active Record fixtures
Rails 4.1 evaluates each fixture's ERB in a separate context, so helper methods Rails 4.1 evaluates each fixture's ERB in a separate context, so helper methods