kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

don't set the hidden checkbox value if it's nil

Browse source
This commit is contained in:
Damien Mathieu 2012-01-06 17:14:49 +01:00
parent aec817269f
commit 69a6381048
2 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
actionpack/lib/action_view/helpers/form_helper.rb
View file

@ -1091,7 +1091,7 @@ module ActionView
else else
add_default_name_and_id(options) add_default_name_and_id(options)
end end
hidden = tag("input", "name" => options["name"], "type" => "hidden", "value" => unchecked_value, "disabled" => options["disabled"]) hidden = unchecked_value ? tag("input", "name" => options["name"], "type" => "hidden", "value" => unchecked_value, "disabled" => options["disabled"]) : ""
checkbox = tag("input", options) checkbox = tag("input", options)
hidden + checkbox hidden + checkbox
end end

8
actionpack/test/template/form_helper_test.rb
View file

@ -374,6 +374,14 @@ class FormHelperTest < ActionView::TestCase
) )
end end
def test_check_box_with_nil_unchecked_value
@post.secret = "on"
assert_dom_equal(
'<input checked="checked" id="post_secret" name="post[secret]" type="checkbox" value="on" />',
check_box("post", "secret", {}, "on", nil)
)
end
def test_check_box_with_multiple_behavior def test_check_box_with_multiple_behavior
@post.comment_ids = [2,3] @post.comment_ids = [2,3]
assert_dom_equal( assert_dom_equal(