1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00

users_dont_suck_but_only_we_suck_and_only_our_tests_are_order_dependent!

Calling ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent! in AS::TestCase makes
everyone's tests order dependent, which should never be done by the framework.
This commit is contained in:
Akira Matsuda 2014-08-12 19:30:05 +09:00
parent c27883c501
commit 6ffb29d24e
8 changed files with 34 additions and 4 deletions

View file

@ -51,3 +51,8 @@ def jruby_skip(message = '')
end
require 'mocha/setup' # FIXME: stop using mocha
# FIXME: we have tests that depend on run order, we should fix that and
# remove this method call.
require 'active_support/test_case'
ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent!

View file

@ -497,3 +497,8 @@ if ActiveSupport::Testing::Isolation.forking_env? && PROCESS_COUNT > 0
# Use N processes (N defaults to 4)
Minitest.parallel_executor = ForkingExecutor.new(PROCESS_COUNT)
end
# FIXME: we have tests that depend on run order, we should fix that and
# remove this method call.
require 'active_support/test_case'
ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent!

View file

@ -340,3 +340,8 @@ def jruby_skip(message = '')
end
require 'mocha/setup' # FIXME: stop using mocha
# FIXME: we have tests that depend on run order, we should fix that and
# remove this method call.
require 'active_support/test_case'
ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent!

View file

@ -13,3 +13,8 @@ I18n.enforce_available_locales = false
require 'active_support/testing/autorun'
require 'mocha/setup' # FIXME: stop using mocha
# FIXME: we have tests that depend on run order, we should fix that and
# remove this method call.
require 'active_support/test_case'
ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent!

View file

@ -201,3 +201,8 @@ module InTimeZone
end
require 'mocha/setup' # FIXME: stop using mocha
# FIXME: we have tests that depend on run order, we should fix that and
# remove this method call.
require 'active_support/test_case'
ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent!

View file

@ -22,10 +22,6 @@ module ActiveSupport
yield if $tags[tag]
end
# FIXME: we have tests that depend on run order, we should fix that and
# remove this method call.
self.i_suck_and_my_tests_are_order_dependent!
include ActiveSupport::Testing::TaggedLogging
include ActiveSupport::Testing::SetupAndTeardown
include ActiveSupport::Testing::Assertions

View file

@ -38,3 +38,8 @@ def jruby_skip(message = '')
end
require 'mocha/setup' # FIXME: stop using mocha
# FIXME: we have tests that depend on run order, we should fix that and
# remove this method call.
require 'active_support/test_case'
ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent!

View file

@ -28,6 +28,10 @@ def jruby_skip(message = '')
end
class ActiveSupport::TestCase
# FIXME: we have tests that depend on run order, we should fix that and
# remove this method call.
self.i_suck_and_my_tests_are_order_dependent!
private
unless defined?(:capture)