From 59f93bbce79407c64636280dc9dfe1170f8b5078 Mon Sep 17 00:00:00 2001 From: Yoshiyuki Hirano Date: Mon, 7 Aug 2017 18:10:31 +0900 Subject: [PATCH] Add git_source to Gemfile for plugin generator --- railties/CHANGELOG.md | 4 ++++ railties/lib/rails/generators/rails/plugin/templates/Gemfile | 1 + railties/test/generators/plugin_generator_test.rb | 5 +++++ 3 files changed, 10 insertions(+) diff --git a/railties/CHANGELOG.md b/railties/CHANGELOG.md index 73793be78c..44449dac0e 100644 --- a/railties/CHANGELOG.md +++ b/railties/CHANGELOG.md @@ -1,3 +1,7 @@ +* Add git_source to `Gemfile` for plugin generator + + *Yoshiyuki Hirano* + * Deprecate support of use `Rails::Application` subclass to start Rails server. *Yuji Yaginuma* diff --git a/railties/lib/rails/generators/rails/plugin/templates/Gemfile b/railties/lib/rails/generators/rails/plugin/templates/Gemfile index 22a4548ff2..290259b4db 100644 --- a/railties/lib/rails/generators/rails/plugin/templates/Gemfile +++ b/railties/lib/rails/generators/rails/plugin/templates/Gemfile @@ -1,4 +1,5 @@ source 'https://rubygems.org' +git_source(:github) { |repo| "https://github.com/#{repo}.git" } <% if options[:skip_gemspec] -%> <%= '# ' if options.dev? || options.edge? -%>gem 'rails', '<%= Array(rails_version_specifier).join("', '") %>' diff --git a/railties/test/generators/plugin_generator_test.rb b/railties/test/generators/plugin_generator_test.rb index 1dfff38543..0782e1ad1d 100644 --- a/railties/test/generators/plugin_generator_test.rb +++ b/railties/test/generators/plugin_generator_test.rb @@ -82,6 +82,11 @@ class PluginGeneratorTest < Rails::Generators::TestCase assert_file "test/integration/navigation_test.rb", /ActionDispatch::IntegrationTest/ end + def test_inclusion_of_git_source + run_generator [destination_root] + assert_file "Gemfile", /git_source/ + end + def test_inclusion_of_a_debugger run_generator [destination_root, "--full"] if defined?(JRUBY_VERSION) || RUBY_ENGINE == "rbx"