kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Job payload should be symmetric across JSON dump/load

Browse source 
Placing non-native JSON data types, like symbols, in the hash to serialize means that the deserialize method will return something different from what was serialized, a common bug and source of frustration for devs.
This commit is contained in:
Mike Perham 2016-03-09 08:56:21 -08:00
parent 5cd2beb013
commit 702ef37767
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
activejob/lib/active_job/core.rb
View file

@ -79,7 +79,7 @@ module ActiveJob
'queue_name' => queue_name, 'queue_name' => queue_name,
'priority' => priority, 'priority' => priority,
'arguments' => serialize_arguments(arguments), 'arguments' => serialize_arguments(arguments),
'locale' => I18n.locale 'locale' => I18n.locale.to_s
} }
end end

6
activejob/test/cases/job_serialization_test.rb
View file

@ -15,13 +15,13 @@ class JobSerializationTest < ActiveSupport::TestCase
end end
test 'serialize includes current locale' do test 'serialize includes current locale' do
assert_equal :en, HelloJob.new.serialize['locale'] assert_equal 'en', HelloJob.new.serialize['locale']
end end
test 'deserialize sets locale' do test 'deserialize sets locale' do
job = HelloJob.new job = HelloJob.new
job.deserialize 'locale' => :es job.deserialize 'locale' => 'es'
assert_equal :es, job.locale assert_equal 'es', job.locale
end end
test 'deserialize sets default locale' do test 'deserialize sets default locale' do