kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Fix assert_in_delta test failure

Browse source 
`assert_in_delta` in `timestamp_test.rb` causes an intermittent test
failure. It looks like that caused by subseconds truncation in MySQL 5.5.

Example:

```
  1) Failure:
  TimestampTest#test_touching_many_attributes_updates_them [/home/travis/build/rails/rails/activerecord/test/cases/timestamp_test.rb:125]:
  Expected |2016-02-06 09:22:10 +0000 - 2016-02-06 09:22:09 UTC| (1.000837185) to be <= 1.
```
This commit is contained in:
Ryuta Kamizono 2016-02-06 20:01:00 +09:00
parent b9a95456a5
commit 71366209d5
1 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
activerecord/test/cases/timestamp_test.rb
View file

@ -98,8 +98,11 @@ class TimestampTest < ActiveRecord::TestCase
task = Task.first
previous_value = task.ending
task.touch(:ending)
now = Time.now.change(usec: 0)
assert_not_equal previous_value, task.ending
assert_in_delta Time.now, task.ending, 1
assert_in_delta now, task.ending, 1
end
def test_touching_an_attribute_updates_timestamp_with_given_time
@ -120,10 +123,12 @@ class TimestampTest < ActiveRecord::TestCase
previous_ending = task.ending
task.touch(:starting, :ending)
now = Time.now.change(usec: 0)
assert_not_equal previous_starting, task.starting
assert_not_equal previous_ending, task.ending
assert_in_delta Time.now, task.starting, 1
assert_in_delta Time.now, task.ending, 1
assert_in_delta now, task.starting, 1
assert_in_delta now, task.ending, 1
end
def test_touching_a_record_without_timestamps_is_unexceptional