kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Don't mutate bind values in Relation

Browse source 
In order to better facilitate refactoring, most places that mutated
`bind_values` have already been removed. One last spot snuck through.
Since we're no longer mutating the array, it also does not need to be
duped in `initialize_copy`.
This commit is contained in:
Sean Griffin 2015-01-19 13:21:18 -07:00
parent 08848a0035
commit 76d7d95790
2 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
activerecord/lib/active_record/relation.rb
View file

@ -33,7 +33,6 @@ module ActiveRecord
# This method is a hot spot, so for now, use Hash[] to dup the hash. # This method is a hot spot, so for now, use Hash[] to dup the hash.
# https://bugs.ruby-lang.org/issues/7166 # https://bugs.ruby-lang.org/issues/7166
@values = Hash[@values] @values = Hash[@values]
@values[:bind] = @values[:bind].dup if @values.key? :bind
reset reset
end end

2
activerecord/lib/active_record/relation/query_methods.rb
View file

@ -909,7 +909,7 @@ module ActiveRecord
end end
end end
bind_values.reject! { |col,_| col.name == target_value } self.bind_values = bind_values.reject { |col,_| col.name == target_value }
end end
def custom_join_ast(table, joins) def custom_join_ast(table, joins)