kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Only use ActionDispatch::ActionableExceptions middleware if local env

Browse source 
When building the default middleware stack, the ActionDispatch::ActionableExceptions
middleware should only be used if the configuration has :consider_all_requests_local
set to true.

There is an existing check #actionable_request? in ActionableExceptions
that will prevent actionable exceptions from being dispatched, which
relies on the "action_dispatch.show_detailed_exceptions" header being
set to false. This check should remain in place as a second line of defense
in case the ActionableExceptions middleware is added back to the application.

However, we can go ahead and remove the middleware from the default stack
when the environment is not local.
This commit is contained in:
Adrianna Chang 2020-11-25 16:15:53 -05:00
parent 2066d64c9b
commit 779bc9987d
2 changed files with 39 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
railties/lib/rails/application/default_middleware_stack.rb
View file

@ -50,7 +50,10 @@ module Rails
middleware.use ::Rails::Rack::Logger, config.log_tags middleware.use ::Rails::Rack::Logger, config.log_tags
middleware.use ::ActionDispatch::ShowExceptions, show_exceptions_app middleware.use ::ActionDispatch::ShowExceptions, show_exceptions_app
middleware.use ::ActionDispatch::DebugExceptions, app, config.debug_exception_response_format middleware.use ::ActionDispatch::DebugExceptions, app, config.debug_exception_response_format
middleware.use ::ActionDispatch::ActionableExceptions
if config.consider_all_requests_local
middleware.use ::ActionDispatch::ActionableExceptions
end
unless config.cache_classes unless config.cache_classes
middleware.use ::ActionDispatch::Reloader, app.reloader middleware.use ::ActionDispatch::Reloader, app.reloader

36
railties/test/application/middleware_test.rb
View file

@ -24,6 +24,41 @@ module ApplicationTests
boot! boot!
assert_equal [
"Webpacker::DevServerProxy",
"ActionDispatch::HostAuthorization",
"Rack::Sendfile",
"ActionDispatch::Static",
"ActionDispatch::Executor",
"ActiveSupport::Cache::Strategy::LocalCache",
"Rack::Runtime",
"Rack::MethodOverride",
"ActionDispatch::RequestId",
"ActionDispatch::RemoteIp",
"Rails::Rack::Logger",
"ActionDispatch::ShowExceptions",
"ActionDispatch::DebugExceptions",
"ActionDispatch::Reloader",
"ActionDispatch::Callbacks",
"ActiveRecord::Migration::CheckPending",
"ActionDispatch::Cookies",
"ActionDispatch::Session::CookieStore",
"ActionDispatch::Flash",
"ActionDispatch::ContentSecurityPolicy::Middleware",
"ActionDispatch::PermissionsPolicy::Middleware",
"Rack::Head",
"Rack::ConditionalGet",
"Rack::ETag",
"Rack::TempfileReaper"
], middleware
end
test "default middleware stack when requests are local" do
add_to_config "config.consider_all_requests_local = true"
add_to_config "config.active_record.migration_error = :page_load"
boot!
assert_equal [ assert_equal [
"Webpacker::DevServerProxy", "Webpacker::DevServerProxy",
"ActionDispatch::HostAuthorization", "ActionDispatch::HostAuthorization",
@ -72,7 +107,6 @@ module ApplicationTests
"Rails::Rack::Logger", "Rails::Rack::Logger",
"ActionDispatch::ShowExceptions", "ActionDispatch::ShowExceptions",
"ActionDispatch::DebugExceptions", "ActionDispatch::DebugExceptions",
"ActionDispatch::ActionableExceptions",
"ActionDispatch::Reloader", "ActionDispatch::Reloader",
"ActionDispatch::Callbacks", "ActionDispatch::Callbacks",
"Rack::Head", "Rack::Head",