kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Slient the deprecation warning for ActiveStorage.replace_on_assign_to_many logged in test cases

Browse source
This commit is contained in:
Abhay Nikam 2021-08-10 22:14:52 +05:30
parent c89f152d8d
commit 77b7835a6a
1 changed files with 25 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

46
activestorage/test/models/attached/many_test.rb
View file

@ -294,18 +294,20 @@ class ActiveStorage::ManyAttachedTest < ActiveSupport::TestCase
test "updating an existing record with attachments when appending on assign" do
append_on_assign do
@user.highlights.attach create_blob(filename: "funky.jpg"), create_blob(filename: "town.jpg")
assert_deprecated do
@user.highlights.attach create_blob(filename: "funky.jpg"), create_blob(filename: "town.jpg")
assert_difference -> { @user.reload.highlights.count }, +2 do
@user.update! highlights: [ create_blob(filename: "whenever.jpg"), create_blob(filename: "wherever.jpg") ]
end
assert_difference -> { @user.reload.highlights.count }, +2 do
@user.update! highlights: [ create_blob(filename: "whenever.jpg"), create_blob(filename: "wherever.jpg") ]
end
assert_no_difference -> { @user.reload.highlights.count } do
@user.update! highlights: [ ]
end
assert_no_difference -> { @user.reload.highlights.count } do
@user.update! highlights: [ ]
end
assert_no_difference -> { @user.reload.highlights.count } do
@user.update! highlights: nil
assert_no_difference -> { @user.reload.highlights.count } do
@user.update! highlights: nil
end
end
end
end
@ -760,20 +762,22 @@ class ActiveStorage::ManyAttachedTest < ActiveSupport::TestCase
test "successfully attaches new blobs and destroys attachments marked for destruction via nested attributes" do
append_on_assign do
town_blob = create_blob(filename: "town.jpg")
@user.highlights.attach(town_blob)
@user.reload
assert_deprecated do
town_blob = create_blob(filename: "town.jpg")
@user.highlights.attach(town_blob)
@user.reload
racecar_blob = fixture_file_upload("racecar.jpg")
attachment_id = town_blob.attachments.find_by!(record: @user).id
@user.update(
highlights: [racecar_blob],
highlights_attachments_attributes: [{ id: attachment_id, _destroy: true }]
)
racecar_blob = fixture_file_upload("racecar.jpg")
attachment_id = town_blob.attachments.find_by!(record: @user).id
@user.update(
highlights: [racecar_blob],
highlights_attachments_attributes: [{ id: attachment_id, _destroy: true }]
)
assert @user.reload.highlights.attached?
assert_equal 1, @user.highlights.count
assert_equal "racecar.jpg", @user.highlights.blobs.first.filename.to_s
assert @user.reload.highlights.attached?
assert_equal 1, @user.highlights.count
assert_equal "racecar.jpg", @user.highlights.blobs.first.filename.to_s
end
end
end