kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

1. Replaced unused variables by _.

Browse source 
2. Typo fixes.
This commit is contained in:
alkesh26 2019-01-22 22:27:01 +05:30
parent e26f0658da
commit 78cf58b765
3 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
actionpack/CHANGELOG.md
View file

@ -82,7 +82,7 @@
* Apply mapping to symbols returned from dynamic CSP sources * Apply mapping to symbols returned from dynamic CSP sources
Previously if a dynamic source returned a symbol such as :self it Previously if a dynamic source returned a symbol such as :self it
would be converted to a string implicity, e.g: would be converted to a string implicitly, e.g:
policy.default_src -> { :self } policy.default_src -> { :self }
@ -135,7 +135,7 @@
*Assain Jaleel* *Assain Jaleel*
* Raises `ActionController::RespondToMismatchError` with confliciting `respond_to` invocations. * Raises `ActionController::RespondToMismatchError` with conflicting `respond_to` invocations.
`respond_to` can match multiple types and lead to undefined behavior when `respond_to` can match multiple types and lead to undefined behavior when
multiple invocations are made and the types do not match: multiple invocations are made and the types do not match:

6
actionpack/test/journey/router_test.rb
View file

@ -284,7 +284,7 @@ module ActionDispatch
def test_generate_missing_keys_no_matches_different_format_keys def test_generate_missing_keys_no_matches_different_format_keys
get "/:controller/:action/:name", to: "foo#bar" get "/:controller/:action/:name", to: "foo#bar"
primarty_parameters = { primary_parameters = {
id: 1, id: 1,
controller: "tasks", controller: "tasks",
action: "show", action: "show",
@ -297,9 +297,9 @@ module ActionDispatch
missing_parameters = { missing_parameters = {
missing_key => "task_1" missing_key => "task_1"
} }
request_parameters = primarty_parameters.merge(redirection_parameters).merge(missing_parameters) request_parameters = primary_parameters.merge(redirection_parameters).merge(missing_parameters)
message = "No route matches #{Hash[request_parameters.sort_by { |k, v|k.to_s }].inspect}, missing required keys: #{[missing_key.to_sym].inspect}" message = "No route matches #{Hash[request_parameters.sort_by { |k, _|k.to_s }].inspect}, missing required keys: #{[missing_key.to_sym].inspect}"
error = assert_raises(ActionController::UrlGenerationError) do error = assert_raises(ActionController::UrlGenerationError) do
@formatter.generate( @formatter.generate(