kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

extract adapter savepoint implementations into abstract/savepoints.rb.

Browse source
This commit is contained in:
Yves Senn 2013-09-30 15:44:51 +02:00
parent 032998ad74
commit 78fcc5fd1a
6 changed files with 27 additions and 46 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
activerecord/lib/active_record/connection_adapters/abstract/savepoints.rb Normal file
View file

@ -0,0 +1,21 @@
module ActiveRecord
module ConnectionAdapters
module Savepoints #:nodoc:
def supports_savepoints?
true
end
def create_savepoint(name = current_savepoint_name)
execute("SAVEPOINT #{name}")
end
def rollback_to_savepoint(name = current_savepoint_name)
execute("ROLLBACK TO SAVEPOINT #{name}")
end
def release_savepoint(name = current_savepoint_name)
execute("RELEASE SAVEPOINT #{name}")
end
end
end
end

1
activerecord/lib/active_record/connection_adapters/abstract_adapter.rb
View file

@ -33,6 +33,7 @@ module ActiveRecord
autoload :Quoting
autoload :ConnectionPool
autoload :QueryCache
autoload :Savepoints
end
autoload_at 'active_record/connection_adapters/abstract/transaction' do

19
activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb
View file

@ -3,6 +3,8 @@ require 'arel/visitors/bind_visitor'
module ActiveRecord
module ConnectionAdapters
class AbstractMysqlAdapter < AbstractAdapter
include Savepoints
class SchemaCreation < AbstractAdapter::SchemaCreation
def visit_AddColumn(o)
@ -194,11 +196,6 @@ module ActiveRecord
true
end
# Returns true, since this connection adapter supports savepoints.
def supports_savepoints?
true
end
def supports_bulk_alter? #:nodoc:
true
end
@ -340,18 +337,6 @@ module ActiveRecord
# Transactions aren't supported
end
def create_savepoint(name = current_savepoint_name)
execute("SAVEPOINT #{name}")
end
def rollback_to_savepoint(name = current_savepoint_name)
execute("ROLLBACK TO SAVEPOINT #{name}")
end
def release_savepoint(name = current_savepoint_name)
execute("RELEASE SAVEPOINT #{name}")
end
# In the simple case, MySQL allows us to place JOINs directly into the UPDATE
# query. However, this does not allow for LIMIT, OFFSET and ORDER. To support
# these, we must use a subquery.

12
activerecord/lib/active_record/connection_adapters/postgresql/database_statements.rb
View file

@ -218,18 +218,6 @@ module ActiveRecord
def rollback_db_transaction
execute "ROLLBACK"
end
def create_savepoint(name = current_savepoint_name)
execute("SAVEPOINT #{name}")
end
def rollback_to_savepoint(name = current_savepoint_name)
execute("ROLLBACK TO SAVEPOINT #{name}")
end
def release_savepoint(name = current_savepoint_name)
execute("RELEASE SAVEPOINT #{name}")
end
end
end
end

6
activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb
View file

@ -430,6 +430,7 @@ module ActiveRecord
include ReferentialIntegrity
include SchemaStatements
include DatabaseStatements
include Savepoints
# Returns 'PostgreSQL' as adapter name for identification purposes.
def adapter_name
@ -620,11 +621,6 @@ module ActiveRecord
true
end
# Returns true, since this connection adapter supports savepoints.
def supports_savepoints?
true
end
# Returns true.
def supports_explain?
true

14
activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb
View file

@ -53,6 +53,8 @@ module ActiveRecord
#
# * <tt>:database</tt> - Path to the database file.
class SQLite3Adapter < AbstractAdapter
include Savepoints
class Version
include Comparable
@ -351,18 +353,6 @@ module ActiveRecord
exec_query(sql, name).rows
end
def create_savepoint(name = current_savepoint_name)
execute("SAVEPOINT #{name}")
end
def rollback_to_savepoint(name = current_savepoint_name)
execute("ROLLBACK TO SAVEPOINT #{name}")
end
def release_savepoint(name = current_savepoint_name)
execute("RELEASE SAVEPOINT #{name}")
end
def begin_db_transaction #:nodoc:
log('begin transaction',nil) { @connection.transaction }
end