Merge pull request #15374 from sgrif/sg-private-properties

Remove AR Properties from the public API

activerecord/CHANGELOG.md

@@ -10,12 +10,6 @@
 
     *arthurnn*
 
-*   Add a properties API to allow custom types and type casting behavior
-    to be specified. Will enable many edge cases to be deprecated, and
-    allow for additional interesting features in the future.
-
-    *Sean Griffin*
-
 *   Fix has_and_belongs_to_many public reflection.
     When defining a has_and_belongs_to_many, internally we convert that to two has_many.
     But as `reflections` is a public API, people expect to see the right macro.

activerecord/lib/active_record/connection_adapters/type/binary.rb

@@ -1,7 +1,7 @@
 module ActiveRecord
   module ConnectionAdapters
     module Type
-      class Binary < Value
+      class Binary < Value # :nodoc:
         def type
           :binary
         end

activerecord/lib/active_record/connection_adapters/type/boolean.rb

@@ -1,7 +1,7 @@
 module ActiveRecord
   module ConnectionAdapters
     module Type
-      class Boolean < Value
+      class Boolean < Value # :nodoc:
         def type
           :boolean
         end

activerecord/lib/active_record/connection_adapters/type/date.rb

@@ -1,7 +1,7 @@
 module ActiveRecord
   module ConnectionAdapters
     module Type
-      class Date < Value
+      class Date < Value # :nodoc:
         def type
           :date
         end

activerecord/lib/active_record/connection_adapters/type/date_time.rb

@@ -1,7 +1,7 @@
 module ActiveRecord
   module ConnectionAdapters
     module Type
-      class DateTime < Value
+      class DateTime < Value # :nodoc:
         include TimeValue
 
         def type

activerecord/lib/active_record/connection_adapters/type/decimal.rb

@@ -1,7 +1,7 @@
 module ActiveRecord
   module ConnectionAdapters
     module Type
-      class Decimal < Value
+      class Decimal < Value # :nodoc:
         include Numeric
 
         def type

activerecord/lib/active_record/connection_adapters/type/float.rb

@@ -1,7 +1,7 @@
 module ActiveRecord
   module ConnectionAdapters
     module Type
-      class Float < Value
+      class Float < Value # :nodoc:
         include Numeric
 
         def type

activerecord/lib/active_record/connection_adapters/type/integer.rb

@@ -1,7 +1,7 @@
 module ActiveRecord
   module ConnectionAdapters
     module Type
-      class Integer < Value
+      class Integer < Value # :nodoc:
         include Numeric
 
         def type

activerecord/lib/active_record/connection_adapters/type/string.rb

@@ -1,7 +1,7 @@
 module ActiveRecord
   module ConnectionAdapters
     module Type
-      class String < Value
+      class String < Value # :nodoc:
         def type
           :string
         end

activerecord/lib/active_record/connection_adapters/type/text.rb

@@ -3,7 +3,7 @@ require 'active_record/connection_adapters/type/string'
 module ActiveRecord
   module ConnectionAdapters
     module Type
-      class Text < String
+      class Text < String # :nodoc:
         def type
           :text
         end

activerecord/lib/active_record/connection_adapters/type/value.rb

@@ -1,7 +1,7 @@
 module ActiveRecord
   module ConnectionAdapters
     module Type
-      class Value
+      class Value # :nodoc:
         attr_reader :precision, :scale, :limit
 
         # Valid options are +precision+, +scale+, and +limit+.

activerecord/lib/active_record/properties.rb

@@ -1,5 +1,5 @@
 module ActiveRecord
-  module Properties
+  module Properties # :nodoc:
     extend ActiveSupport::Concern
 
     Type = ConnectionAdapters::Type
@@ -64,19 +64,7 @@ module ActiveRecord
 
       # Returns an array of column objects for the table associated with this class.
       def columns
-        @columns ||= add_user_provided_columns(connection.schema_cache.columns(table_name)).each do |column|
+        @columns ||= add_user_provided_columns(connection.schema_cache.columns(table_name))
-          if Type::DecimalWithoutScale === column.cast_type
-            ActiveSupport::Deprecation.warn <<-MESSAGE.strip_heredoc
-              Decimal columns with 0 scale being automatically treated as integers
-              is deprecated, and will be removed in a future version of Rails. If
-              you'd like to keep this behavior, add
-
-                property :#{column.name}, Type::Integer.new
-
-              to your #{name} model.
-            MESSAGE
-          end
-        end
       end
 
       # Returns a hash of column objects for the table associated with this class.