kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Merge pull request #36255 from eugeneius/sqlite_savepoint_support

Browse source 
Remove SQLite version support caveats [ci skip]
This commit is contained in:
Kasper Timm Hansen 2019-05-12 15:42:17 -05:00 committed by GitHub
commit 8365b7ded6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 5 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb
View file

@ -205,8 +205,6 @@ module ActiveRecord
# In order to get around this problem, #transaction will emulate the effect # In order to get around this problem, #transaction will emulate the effect
# of nested transactions, by using savepoints: # of nested transactions, by using savepoints:
# https://dev.mysql.com/doc/refman/5.7/en/savepoint.html # https://dev.mysql.com/doc/refman/5.7/en/savepoint.html
# Savepoints are supported by MySQL and PostgreSQL. SQLite3 version >= '3.6.8'
# supports savepoints.
# #
# It is safe to call this method if a database transaction is already open, # It is safe to call this method if a database transaction is already open,
# i.e. if #transaction is called within another #transaction block. In case # i.e. if #transaction is called within another #transaction block. In case

2
activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb
View file

@ -735,7 +735,7 @@ module ActiveRecord
# #
# CREATE UNIQUE INDEX index_accounts_on_branch_id_and_party_id ON accounts(branch_id, party_id) WHERE active # CREATE UNIQUE INDEX index_accounts_on_branch_id_and_party_id ON accounts(branch_id, party_id) WHERE active
# #
# Note: Partial indexes are only supported for PostgreSQL and SQLite 3.8.0+. # Note: Partial indexes are only supported for PostgreSQL and SQLite.
# #
# ====== Creating an index with a specific method # ====== Creating an index with a specific method
# #

4
activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb
View file

@ -48,8 +48,8 @@ module ActiveRecord
end end
module ConnectionAdapters #:nodoc: module ConnectionAdapters #:nodoc:
# The SQLite3 adapter works SQLite 3.6.16 or newer # The SQLite3 adapter works with the sqlite3-ruby drivers
# with the sqlite3-ruby drivers (available as gem from https://rubygems.org/gems/sqlite3). # (available as gem from https://rubygems.org/gems/sqlite3).
# #
# Options: # Options:
# #

4
activerecord/lib/active_record/transactions.rb
View file

@ -164,12 +164,12 @@ module ActiveRecord
# end # end
# end # end
# #
# only "Kotori" is created. This works on MySQL and PostgreSQL. SQLite3 version >= '3.6.8' also supports it. # only "Kotori" is created.
# #
# Most databases don't support true nested transactions. At the time of # Most databases don't support true nested transactions. At the time of
# writing, the only database that we're aware of that supports true nested # writing, the only database that we're aware of that supports true nested
# transactions, is MS-SQL. Because of this, Active Record emulates nested # transactions, is MS-SQL. Because of this, Active Record emulates nested
# transactions by using savepoints on MySQL and PostgreSQL. See # transactions by using savepoints. See
# https://dev.mysql.com/doc/refman/5.7/en/savepoint.html # https://dev.mysql.com/doc/refman/5.7/en/savepoint.html
# for more information about savepoints. # for more information about savepoints.
# #