1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00

Merge pull request #28757 from edwardmp/log-actioncable-write-read-errors

Log any write errors originating from the socket
This commit is contained in:
Rafael França 2017-04-19 19:35:07 -04:00 committed by GitHub
commit 89be09982a
2 changed files with 8 additions and 1 deletions

View file

@ -1 +1,7 @@
* ActionCable socket errors are now logged to the console
Previously any socket errors were ignored and this made it hard to diagnose socket issues (e.g. as discussed in #28362).
*Edward Poot*
Please check [5-1-stable](https://github.com/rails/rails/blob/5-1-stable/actioncable/CHANGELOG.md) for previous changes.

View file

@ -126,7 +126,8 @@ module ActionCable
end
def on_error(message) # :nodoc:
# ignore
# log errors to make diagnosing socket errors easier
logger.error "WebSocket error occurred: #{message}"
end
def on_close(reason, code) # :nodoc: