mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
Don't use assert_nothing_raised when assert_equal is used
This commit is contained in:
parent
978c568a7b
commit
8cfe95d719
3 changed files with 10 additions and 22 deletions
|
@ -16,10 +16,8 @@ class ParametersTaintTest < ActiveSupport::TestCase
|
|||
end
|
||||
|
||||
test "fetch doesnt raise ParameterMissing exception if there is a default" do
|
||||
assert_nothing_raised do
|
||||
assert_equal "monkey", @params.fetch(:foo, "monkey")
|
||||
assert_equal "monkey", @params.fetch(:foo) { "monkey" }
|
||||
end
|
||||
assert_equal "monkey", @params.fetch(:foo, "monkey")
|
||||
assert_equal "monkey", @params.fetch(:foo) { "monkey" }
|
||||
end
|
||||
|
||||
test "permitted is sticky on accessors" do
|
||||
|
|
|
@ -27,16 +27,10 @@ class ActiveModelMassUpdateProtectionTest < ActiveSupport::TestCase
|
|||
|
||||
test "permitted attributes can be used for mass updating" do
|
||||
params = ProtectedParams.new({ "a" => "b" }).permit!
|
||||
assert_nothing_raised do
|
||||
assert_equal({ "a" => "b" },
|
||||
Account.new.sanitize_for_mass_assignment(params))
|
||||
end
|
||||
assert_equal({ "a" => "b" }, Account.new.sanitize_for_mass_assignment(params))
|
||||
end
|
||||
|
||||
test "regular attributes should still be allowed" do
|
||||
assert_nothing_raised do
|
||||
assert_equal({ a: "b" },
|
||||
Account.new.sanitize_for_mass_assignment(a: "b"))
|
||||
end
|
||||
assert_equal({ a: "b" }, Account.new.sanitize_for_mass_assignment(a: "b"))
|
||||
end
|
||||
end
|
||||
|
|
|
@ -34,21 +34,17 @@ class ForbiddenAttributesProtectionTest < ActiveRecord::TestCase
|
|||
def test_permitted_attributes_can_be_used_for_mass_assignment
|
||||
params = ProtectedParams.new(first_name: 'Guille', gender: 'm')
|
||||
params.permit!
|
||||
assert_nothing_raised do
|
||||
person = Person.new(params)
|
||||
person = Person.new(params)
|
||||
|
||||
assert_equal 'Guille', person.first_name
|
||||
assert_equal 'm', person.gender
|
||||
end
|
||||
assert_equal 'Guille', person.first_name
|
||||
assert_equal 'm', person.gender
|
||||
end
|
||||
|
||||
def test_regular_hash_should_still_be_used_for_mass_assignment
|
||||
assert_nothing_raised do
|
||||
person = Person.new(first_name: 'Guille', gender: 'm')
|
||||
person = Person.new(first_name: 'Guille', gender: 'm')
|
||||
|
||||
assert_equal 'Guille', person.first_name
|
||||
assert_equal 'm', person.gender
|
||||
end
|
||||
assert_equal 'Guille', person.first_name
|
||||
assert_equal 'm', person.gender
|
||||
end
|
||||
|
||||
def test_protected_attributes_cannot_be_used_for_mass_assignment
|
||||
|
|
Loading…
Reference in a new issue