1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00

Use content_tag here instead of manually building HTML

This commit is contained in:
Santiago Pastorino 2012-08-03 02:14:29 -03:00
parent 572ecaef17
commit 8f8d8eb146

View file

@ -4,6 +4,9 @@ module ActionView
# Provides a set of methods for making it easier to debug Rails objects. # Provides a set of methods for making it easier to debug Rails objects.
module Helpers module Helpers
module DebugHelper module DebugHelper
include TagHelper
# Returns a YAML representation of +object+ wrapped with <pre> and </pre>. # Returns a YAML representation of +object+ wrapped with <pre> and </pre>.
# If the object cannot be converted to YAML using +to_yaml+, +inspect+ will be called instead. # If the object cannot be converted to YAML using +to_yaml+, +inspect+ will be called instead.
# Useful for inspecting an object at the time of rendering. # Useful for inspecting an object at the time of rendering.
@ -26,10 +29,11 @@ module ActionView
def debug(object) def debug(object)
begin begin
Marshal::dump(object) Marshal::dump(object)
"<pre class='debug_dump'>#{h(object.to_yaml).gsub(" ", "&nbsp; ")}</pre>".html_safe object = ERB::Util.html_escape(object.to_yaml).gsub(" ", "&nbsp; ").html_safe
content_tag(:pre, object, :class => "debug_dump")
rescue Exception # errors from Marshal or YAML rescue Exception # errors from Marshal or YAML
# Object couldn't be dumped, perhaps because of singleton methods -- this is the fallback # Object couldn't be dumped, perhaps because of singleton methods -- this is the fallback
"<code class='debug_dump'>#{h(object.inspect)}</code>".html_safe content_tag(:code, object.to_yaml, :class => "debug_dump")
end end
end end
end end