kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Modify assert_storage_performance to be quiet by default

Browse source 
Even though encryption performance test have been ignored in 1fff866,
they're still included when using `bin/test` as the executable, and the
output could be confusing.

Following the approach used in ed8667d, this assertion is now quiet by
default.
This commit is contained in:
Ricardo Díaz 2021-05-02 23:44:58 -05:00
parent dd5886d00a
commit 8fd352749d
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
activerecord/test/cases/encryption/performance/storage_performance_test.rb
View file

@ -45,13 +45,16 @@ class ActiveRecord::Encryption::StoragePerformanceTest < ActiveRecord::Encryptio
end
private
def assert_storage_performance(size:, overload_less_than:)
def assert_storage_performance(size:, overload_less_than:, quiet: true)
clear_content = SecureRandom.urlsafe_base64(size).first(size) # .alphanumeric is very slow for large sizes
encrypted_content = encryptor.encrypt(clear_content)
puts "#{clear_content.bytesize}; #{encrypted_content.bytesize}; #{(encrypted_content.bytesize / clear_content.bytesize.to_f)}"
overload_factor = encrypted_content.bytesize.to_f / clear_content.bytesize
if !quiet || overload_factor > overload_less_than
puts "#{clear_content.bytesize}; #{encrypted_content.bytesize}; #{(encrypted_content.bytesize / clear_content.bytesize.to_f)}"
end
assert\
overload_factor <= overload_less_than,
"Expecting an storage overload of #{overload_less_than} at most for #{size} bytes, but got #{overload_factor} instead"