kotovalexarian-likes-github
/
rails--rails
mirror of https://github.com/rails/rails.git
1
0
Fork 0
Code Releases Activity

Remove deprecated `ActiveStorage::Downloading`

This commit is contained in:
Rafael Mendonça França 2020-05-07 16:13:56 -04:00
parent 426967c6f5
commit 92a8e1d7c5
No known key found for this signature in database
GPG Key ID: FC23B6D0F1EEE948
3 changed files with 7 additions and 48 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
activestorage/CHANGELOG.md
View File

@ -1,7 +1,11 @@
* Remove deprecated `ActiveStorage::Downloading`.
*Rafael Mendonça França*
* Add per-environment configuration support
*Pietro Moro*
* The Poppler PDF previewer renders a preview image using the original
document's crop box rather than its media box, hiding print margins. This
matches the behavior of the MuPDF previewer.

47
activestorage/lib/active_storage/downloading.rb
View File

@ -1,47 +0,0 @@
# frozen_string_literal: true
require "tmpdir"
require "active_support/core_ext/string/filters"
module ActiveStorage
module Downloading
def self.included(klass)
ActiveSupport::Deprecation.warn <<~MESSAGE.squish, caller_locations(2)
ActiveStorage::Downloading is deprecated and will be removed in Active Storage 6.1.
Use ActiveStorage::Blob#open instead.
MESSAGE
end
private
# Opens a new tempfile in #tempdir and copies blob data into it. Yields the tempfile.
def download_blob_to_tempfile #:doc:
open_tempfile_for_blob do |file|
download_blob_to file
yield file
end
end
def open_tempfile_for_blob
tempfile = Tempfile.open([ "ActiveStorage", blob.filename.extension_with_delimiter ], tempdir)
begin
yield tempfile
ensure
tempfile.close!
end
end
# Efficiently downloads blob data into the given file.
def download_blob_to(file) #:doc:
file.binmode
blob.download { |chunk| file.write(chunk) }
file.flush
file.rewind
end
# Returns the directory in which tempfiles should be opened. Defaults to +Dir.tmpdir+.
def tempdir #:doc:
Dir.tmpdir
end
end
end

2
guides/source/6_1_release_notes.md
View File

@ -240,6 +240,8 @@ Please refer to the [Changelog][active-storage] for detailed changes.
### Removals
* Remove deprecated `ActiveStorage::Downloading`.
### Deprecations
* Deprecate `Blob.create_after_upload` in favor of `Blob.create_and_upload`.